2024_apr_epic: BUG: Test_slow is not preformatting team data files into proper format for use by the model

lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.

GNU General Public License v3.0

9 stars 23 forks source link

2024_apr_epic: BUG: Test_slow is not preformatting team data files into proper format for use by the model #3134

Closed jamesmrollins closed 2 months ago

jamesmrollins commented 3 months ago

When the user uploads a team data file in the Test_slow project, the system is not changing the format of the file from the Power BI export (all variables in a single cell), to a Vensim standard format (all variables parsed into separate addressed cells).

This appears to indicate the code that accomplishes the conversion is not incorporated in the 3.7 application.
Testing shows that the code is working fine in the Sim UI PROD project.

Results in nonsense values in the model. Closer inspection reveals incorrect values in Team Data.

Power BI Export Format - This is the file that is in the directory, should be converted by the time in lands in the Epicenter Model Directory.

Sim UI Converted Format - This what the file should look like to be readable by the Sim UI.

tejaspesquare commented 3 months ago

@jamesmrollins - This is in-progress. We will let you know in case more details required to troubleshoot the issue.

lijenn commented 2 months ago

Discussed at Stand Up 3/31/24: @tejaspesquare will continue working with David from Forio to resolve this issue. The Dev team found inconsistencies in the data files in both Prod and Break Fix.

ljmoody commented 2 months ago

Discussed at 4/3/24: @tejaspesquare says effort is halfway done. When uploading to Sim UI, the raw file is not uploading correctly; but in production it is. Has to do with a file structure change which requires a different API. Conversion is being handled by Dev team in Test-Slow.

lijenn commented 2 months ago

Discussed 4/7 Sim UI Standup:

@tejaspesquare 70% of the work for this has already been completed, remaining is expected to be done this week.

tejaspesquare commented 2 months ago

@jamesmrollins , @ljmoody & @lijenn - File conversion is now functioning properly. & code moved to TEST-Slow environment.

Original File (Raw model file)

After Conversion (On Epicenter)

API Response (PSY Model)

ljmoody commented 2 months ago

4/14 standup:

@ljmoody will test this week.

ljmoody commented 2 months ago

@tejaspesquare, testing in Test-Slow verified that: ✅ data files uploaded are preformatted into proper format for use by the Sim.

Screenshot below is of testing. -- Created a new team, renamed data file (base files is "soft moss" file - the same file that was returning incorrect values), uploaded to team, and numbers showing are as expected.
Moving this card to Done column within bug_tracker

fyi: @jamesmrollins @lijenn