search

lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
9 stars 23 forks source link

2024_06_epic: Bug: Run IDs are not preserved #3159

Closed jamesmrollins closed 1 week ago

jamesmrollins commented 1 month ago

What happens

  1. When user navigates to Dynamic Dashboard, selects a Team Data File and clicks "Go" the models all run and return base case values.
  2. When the user navigates to the model and runs the model, values are returned to the individual model.
  3. When the user navigates back to the Dynamic Dashboard, the Run IDs are lost and the models are reset to zero.
  4. IF the user logs out from the Dynamic Dashboard (DD) after the Team Data is loaded and models set to time zero, then the models are reset.

What should happen

  1. When the user performs steps above, the Run ID should be preserved for all models.
  2. With number 2 above, where an individual model is run, and the user returns to the DD, then the stock values should be reflected in the DD.
  3. An individual model can be reset and rerun from the model level, with the current Team Data, without disrupting the remaining models.
  4. If the user reloads a Team Data file, then all models are reset and run to zero.

Next Steps

  1. Need verify what commands are being issued to the back end when user navigates between models.
  2. Check Play button associated code that may be issuing a re-run or reset command.
  3. Modify play button functionality to not reset if the model has been mounted or run.
  4. Reset only when Reset button is clicked.
  5. Runs can be restored using, POST .../api/v3/va/va-psd-dev/run/world/

Resolve Estimate: 5/24

lzim commented 4 weeks ago

wk5 2024_05 #systems_sme_workflow @lzim @dlkibbe

@jamesmrollins - Unclear about when this will be resolved for #systems_sme_workflow closing #763. Please advise. Thanks!

FYI: @dlounsbu

jamesmrollins commented 4 weeks ago

@lzim @lijenn @ljmoody @dlkibbe @dlounsbu

5/29 Demo Call

lzim commented 2 weeks ago

wk2 2024_06 - #sim_ui_workflow @jamesmrollins @ljmoody @lijenn

ljmoody commented 1 week ago

@lzim, my understanding is that yes, this issue is resolved and the fix was migrated to PROD. As such, I'm closing this card.