2024_09: TEST Team Care (AGG) Flow Meters

[ljmoody]

All TEST cards for Flow:

3199 CC & MM

3072 PSY

3204 Team Care (AGG)

3205 Team Flow (SP)

AC:

• [ ] provide feedback to DEV
• [ ] stocks have color code key

• [ ] all feedback to DEV is addressed and/or incorporated

  ~- [ ] When the user clicks on the "Flow" icon from the Dynamic Decision Dashboard, the user is presented with a new browser tab with the diagram depicted in the wireframe.~

• [ ] The flows and stock variables are proportional to each other based on the instructions in the wireframe.
• [ ] Flows are labeled with actual values.
• [ ] Stocks change color based on rules depicted in the wireframe.

[lzim]

wk4 2024_07 @lzim - working to finalize #3168 ASAP for MTL 3.7 Live consults scheduled for wk2 2024_08

sim_ui_workflow - Team Care Flows in TEST have mathematical errors and graphical edits needed

@matomasz @lijenn @ljmoody @jamesmrollins @tejaspesquare

Mathematical errors

• [ ] 1. The rate dials and the flows do not sum.
• [ ] 2. The flows have negative values

Graphical improvements

• [ ] 1. The flows "bend" to/from the flows, creating unnecessary visual complexity AND challenges when zooming in to read the small text values. Recommend that there are no turns in the flows, just parallel left to right viewing to/from the stocks.
• [ ] 2. The stocks require a scale indicator on the tick marks.

[ljmoody]

@tejaspesquare - following up on this card. Do you have an update for us or rough ETA for when we can test?

• [ ] We need a message to clarify how to interpret color stock indicators, same comment as on #3072 Recommend a color key that with this text below Red = Inflow > Outflow Blue = Outflow > Inflow

[tejaspesquare]

Hello @ljmoody,

The implementation of a color key on the Flow meter is expected to result in the displacement of the current position of the Flow meter. This matter will be addressed solely by the designer. Currently, the designer is occupied with other responsibilities within our organization for a few days. Once he becomes available intermittently, we will request him to complete this task. I will provide an update once it has been developed. Thanks!

[matthewtomo]

Discussed DEV standup 8/9/2024 @matthewtomo @tejaspesquare

• We need to makes sure that the flow arms are correctly proportioned based on the weight of the values they represent (behavior according to wireframes).
• We need to make sure that the flow dials are representing the sum of all of the values flowing through them, not just AUD (behavior according to wireframes).
• @tejaspesquare or someone on dev will look at the current code logic for the flows and dials and report back here.
• @jamesmrollins do we need a more parallel design for the flow between the dials, flows, and stocks?:

Graphical improvements

• [ ] 1. The flows "bend" to/from the flows, creating unnecessary visual complexity AND challenges when zooming in to read the small text values. Recommend that there are no turns in the flows, just parallel left to right viewing to/from the stocks.

[matthewtomo]

Discussed DEV Standup 8/12/24 @matthewtomo @tejaspesquare

• Dev team requires a new model parameters test file consistent with the change in the Agg, MM, and PSY model files
• Dev is currently testing this bug on an older local dev branch without the model changes

fyi: @jamesmrollins @ljmoody @lijenn

[matthewtomo]

Discussed Dev Standup8/14/2024 @matthewtomo @tejaspesquare

• Starting rate -> start rate issue is resolved

• We need to makes sure that the flow arms are correctly proportioned based on the weight of the values they represent (behavior according to wireframes).
• We need to make sure that the flow dials are representing the sum of all of the values flowing through them, not just AUD (behavior according to wireframes).

• The Flows should now be following the correct logic. This is ~not yet~ now available on the deployed DEV environment.

• [x] ~@tejaspesquare will send an update when the code is available in DEV environment.~

[matthewtomo]

@tejaspesquare

As discussed Reg #3204, MM- Mathematical errors have been resolved & moved to DEV. Could you please verify values are populated on rate dial & stock box are fine.

Earlier Observations-

1. The rate dials and the flows do not sum.
2. The flows have negative values

In-progress:

1. Proportion of flow line (Height/Width)
2. Handling of decimal numbers in stock

1. The rate dials and the flows do not sum: It looks like the flow Dials are mostly summing correctly for the MM Flow Diagram in DEV. I see two current issues: 1.1. This dial is not summing with the correct rounding: 6.33 + 20.57 + 7.78 + 20.93 = 55.61

1.2. This dial needs to be rounded correctly.

2. The flows have negative values: Most of the rate dials look improved, however: 2.1. These values need more spacing:

[matthewtomo]

Discussed #DEV_Standup @matthewtomo @tejaspesquare

• All above issues have been addressed besides this one:

This dial is not summing with the correct rounding: 6.33 + 20.57 + 7.78 + 20.93 = 55.61

• Dev team has been sent the model file associated with the bug to investigate further

[tejaspesquare]

Hello @matomasz

This dial is not summing with the correct rounding: 6.33 + 20.57 + 7.78 + 20.93 = 55.61

Our analysis suggests that the dialMax value is configured to 50 according to the code. Therefore, if possible, could you please verify with James whether there is any business condition or rule that put the maximum value for this setting?

Thank You!

[jamesmrollins]

@tejaspesquare FYI: @matthewtomo

• We should not set arbitrary max values for any of the stocks or flows. They should be set by the model variable value. The actual number expressed in the dial should be rounded to XX.XX.
• It appears the logic highlighted above controls the needle position. This is fine for needle position, but the displayed number should be the actual value returned by the API.

[matthewtomo]

Discussed Dev Standup wk4 2024_08 @matthewtomo @tejaspesquare

• It is okay for the "needle" of the dial to have a max value, but the number on the dial should be the actual value of the flow being measured.
• If the actual value exceeds the max value of the needle, then the needle should be set to the maximum position, but the number of the dial should be the exact number (not the max for the needle).
• For now, 100 might be a better "max value" for the dial needle, but we still want the number to be shown if it exceeds 100.
• @matthewtomo can confirm with James that this is sufficient behavior.

[matthewtomo]

Discussed Dev Standup wk_1 2024_9 @matthewtomo @tejaspesquare

• Current flow dial is not capable of showing the actual value if it exceeds the max value for the needle of the dial.
• @tejaspesquare will investigate this issue in order to better estimate the scope of this task.
• After the issue is visited, @tejaspesquare will be able to provide an estimate here.

fyi: @jamesmrollins

[matthewtomo]

Ad Hoc Meeting with James @matthewtomo @jamesmrollins

• We would like for all of the flow dials to be proportional. Could we follow a similar logic to the flow arms? (get the largest flow in the diagram and set that as the "dialMaxValue")?
• @tejaspesquare If you could provide an estimate, how long do you think it would take to implement that as a change?

fyi: @tejaspesquare

[tejaspesquare]

Hi Matthew,

• We would like for all of the flow dials to be proportional. Could we follow a similar logic to the flow arms? (get the largest flow in the diagram and set that as the "dialMaxValue")?
• @tejaspesquare If you could provide an estimate, how long do you think it would take to implement that as a change?

We are currently unable to accurately assess the efforts needed for this change, as it likely requires the introduction of new code and the identification of functions that require modification in multiple areas, not solely on the Home page but also on simulation. To provide a more precise estimate, it will be necessary to conduct a proof of concept (POC) on one of the models initially.

[matthewtomo]

@tejaspesquare

• Sounds good. Would we be able to conduct a POC using the CC model flow diagram?

[matthewtomo]

Discussed Dev Standup wk_1 2024_9 @matthewtomo @tejaspesquare

• Work on this POC has started.
• More updates next week.

[tejaspesquare]

Hello @matomasz ,

We have successfully completed the POC and development for the CC model today. It is now accessible in the development environment. Please confirm at your earliest convenience so that we may proceed to implement the same solutions for the other models.

[matthewtomo]

Discussed Dev Standup wk_2 2024_9 @matthewtomo @tejaspesquare

• [x] @matthewtomo will review this behavior in the DEV environment for CC and report back here.

[matthewtomo]

@tejaspesquare

• Yes, the POC for the CC flow diagram looks very good
• We would like to move forward with that implementation of the maxDialValue for all of the other flow diagrams

[matthewtomo]

Discussed Friday Dev Standup wk_2 2024_9 @matthewtomo @tejaspesquare

• Dev has started working on implementing this change into the other Flow Diagrams