lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
9 stars 23 forks source link

2024_07: BUG: PROD team data upload is inconsistent via DDD #3220

Closed ljmoody closed 2 weeks ago

ljmoody commented 1 month ago

*may be related to #3216.

Discovered 7/18/2024 by Jenn and Laura in PROD instance, both Edge and Chrome browsers. Uploading team data files via the Admin Dashboard and the DDD is highly inconsistent today.

When attempting to upload or add a team data file to a team in PROD via the Admin Dashboard we observed the following on different attempts:

lijenn commented 1 month ago

Discussed 7/19 Team Praxis Call:

matthewtomo commented 1 month ago

Bug experienced during 7/22 Support Systems SME and Sim UI Workflows Meeting. Attached is a screenshot of the issue occurring with errors shown in console.

File uploaded successfully, but when attempting to start a session, the ellipses loading indicator continued without stopping for 15+ minutes in PROD.

image

@tejaspesquare

fyi: @jamesmrollins @lijenn @ljmoody @dlounsbu @dlkibbe

lzim commented 1 month ago

Let's keep a very close eye on the related cards as we prep these consults for scheduling wk2 2024_08. Thanks for the hard work, everyone!

matthewtomo commented 1 month ago

Discussed support_workflow @ljmoody @lijenn @matthewtomo

@lzim @jamesmrollins @tejaspesquare

matthewtomo commented 1 month ago

Discussed 7/25 Standup with Dev @matthewtomo @tejaspesquare

image

tejaspesquare commented 1 month ago

Hello @jamesmrollins , @ljmoody , @lijenn , @matthewtomo

I proceeded with testing on the Dev branch for the Team setup, addressing the remaining 3 use cases that were pending from yesterday's execution. Please review the most recent outcome.

Dev_SIMUI_Team Setup_25-26July

Furthermore, we have also addressed a scenario where the user configures a team without adding any members. Note: The default lead user is loaded at the beginning itself, unlike this user added to 3 worlds after pressing Done. image

Kindly provide confirmation regarding the use case mentioned by @matthewtomo above, specifically case about the possibility of allowing a logged-in Admin user to downgrade to Team Lead while performing team setup. If this scenario is likely possible then additional time (POC + Development) will be needed to address it. Furthermore, there are also anticipated changes on the Forio side too. If not, we will restrict user from doing it.

Thanks!

matthewtomo commented 1 month ago

Discussed DEV Standup 7/29/2024 @matthewtomo @tejaspesquare

fyi: @jamesmrollins @lijenn @ljmoody

ljmoody commented 1 month ago

@matthewtomo, I tested in DEV instance, Chrome browser, using VA laptop.

Test 1:

Test 2:

ljmoody commented 1 month ago

@matthewtomo, I tested in TEST instance, Chrome browser, using VA laptop. Logged in as an Administrator.

Test 1:

Test 2:

tejaspesquare commented 1 month ago

Hello @ljmoody

@matthewtomo, I tested in TEST instance, Chrome browser, using VA laptop. Logged in as an Administrator.

As we anticipate new developments regarding Team Setup transitioning from Development to Testing and subsequently to Production, following the validation of all use cases, it is advisable to refrain from conducting tests in the Testing environment at this time. Thanks!

tejaspesquare commented 1 month ago

Hello @ljmoody

Test 1:

  • created a new team, did not manually add any users
  • all 3 worlds were created
  • Default Team Lead is added to teams automatically upon setup
  • 6 default users were not added

Thanks for sharing your test result. Regarding your concern "6 default users were not added",

Result you have noticed is expected one on Dev instance. We have not configured all users in our local instance. image

FYI - @jamesmrollins , @lijenn , @matomasz

tejaspesquare commented 1 month ago

Hello @ljmoody, @lijenn, @matomasz

Just FYI - Currently, we have set up all default users for the Development instance to facilitate your testing. image

ljmoody commented 1 month ago

@matthewtomo, FYI: Tested in DEV instance this morning, Chrome browser, on VA laptop, with VA login as administrator.

Test 1: no users added during team creation

image

Test 2: 2 users added during team creation

image

tejaspesquare commented 1 month ago

Hello @ljmoody, @lijenn, @matomasz,

Team Setup & Team Data Upload via DDD: could you please inform us once you are done with the execution on Dev instance of all use cases regarding Team Setup. We will prepare for code migration up to production.

Team Data Upload via DDD:

Uploading image

After Deleting image image

Note: Team Data upload via Admin Dashboard too fixed but checking for delete operation. Once this is covered, we will make available for your testing.

matthewtomo commented 1 month ago

@tejaspesquare

tejaspesquare commented 1 month ago

Hi @matthewtomo,

We have added Default users (live) into DEV instance just to support for your execution & extra person (Roshan Shah) is our internal user. For time being we will make changes as requested (Remove Roshan Shah & Adding Matthew Tomaszewski).

Additional question:

  • Is there a reason why we are currently testing in the DEV branch as opposed to the TEST branch?

So far, Team Setup issues have been resolved according to each specific request, however, we were unaware of the complete set of business rules. Therefore, we aimed to establish a stable version that aligns with the requirements.

tejaspesquare commented 1 month ago

Hello @ljmoody, @lijenn, @matthewtomo,

Would it be acceptable to everyone if we proceed with migrating the code related to the Team setup and the Inconsistency DDD Team Data file to the TEST environment?

tejaspesquare commented 1 month ago

Hello @ljmoody, @lijenn, @matomasz,

Note: Team Data upload via Admin Dashboard too fixed but checking for delete operation. Once this is covered, we will make available for your testing.

This is fixed & can be verified on Dev instance.

Uploaded Fiel in 2 different Groups image

Uploading fresh file other than above two groups, previously selected groups is not affected as expected image

matthewtomo commented 1 month ago

Discussed in DEV Standup 8/1/2024 @matthewtomo @tejaspesquare

fyi: @jamesmrollins @lijenn @ljmoody

tejaspesquare commented 1 month ago

Hello @jamesmrollins , @ljmoody , @lijenn , @matomasz ,

Kindly be advised that the migration of code from the Development environment to the TEST environment has been successfully accomplished.

ljmoody commented 1 month ago

8/2/24 update from Tejas:

ljmoody commented 1 month ago

8/5/24 user testing in TEST instance for #3220 & 3216. fyi @matthewtomo - esp. step 4. And FYI: I wasn't able to test in Edge because of time constraints.

Chrome UX:

  1. Logged on with VA account, administrator_login.
  2. Created a new team: 3216_3220_chrome (did not manually add any users).
  3. Uploaded a data file via Settings>Data>Add>Upload: image SIDE QUESTION: if a user uploads a data file to a _team world, should that data file be uploaded to _team, _shared, and _ind?
  4. Team was not listed under Select Team dropdown in Administrator Dashboard.
  5. Refreshed browser. Now my team is available to select. Navigated to team's Home Page: image
  6. Data file is showing in both expected places: image
  7. I was able to run the data file; all 5 modules initialized. image
  8. Uploaded a second data set to the same team - this time via DDD's Team Data window: image
  9. Confirmed that the data file is immediately available in both expected places (and returned same DDD results when run): image
lijenn commented 1 month ago

^ Whoops! We might have been testing at the same time @ljmoody! Despite getting the green pop-up saying my data file was successfully uploaded, I am unable to see the data file show up in my dropdown list for my 2 teams in test, #3203_test2_chrome_jenn_2024_08_05 and #3203_chrome_jenn_2024_08_05:

I got these console logs in Chrome, but not sure if it's helpful since only one person can do testing at a time.

Leaving them here in case it's helpful (seems like it would be expected since I'm seeing time out logs that's probably coming from ANDON #3232?) and I will test this evening again:

image image image

FYI @matomasz

tejaspesquare commented 1 month ago

@ljmoody, @lijenn, @matomasz,

FYI - The error message "episodes did not create" on the Admin Dashboard has been resolved in the DEV and TEST environments. Once the code is deployed to the PROD environment, this issue will no longer be present.

matthewtomo commented 1 month ago

@dlkibbe @dlounsbu It looks like you might want to push back the work session, as not all of the changes are ready to go through.

matthewtomo commented 4 weeks ago

Tested 8/9/2024 on Non VA machine

Chrome:

image image

Edge:

image image

matthewtomo commented 2 weeks ago

Discussed 8/20/2024 @matthewtomo @jamesmrollins @lijenn

matthewtomo commented 2 weeks ago

week 3 2024_08 Praxis Meeting @matthewtomo @jamesmrollins @ljmoody