lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
15 stars 23 forks source link

2024_11: remove AGG and SP from outward-facing Sim, Demo, & Team projects + Documentation #3261

Open ljmoody opened 2 months ago

ljmoody commented 2 months ago

Decision at wk3 2024_09 #sim_ui_workflow:

AC:

ljmoody commented 2 months ago

Previously identified before tracking via this card:

ljmoody commented 2 months ago

Tejas would like to know if the entire name is desired or an acronym could be used in this case. The whole name adds more visual clutter, yet the acronyms aren't widely used (not yet, anyway) for these.

@lzim, what is your preference?

ljmoody commented 2 months ago

9/19/24 comment from Tejas (copied from issue #3158, before tracking this effort in a unique card):

Hello @ljmoody , As per notes from Teams:

DECISION: ALL instances of "AGGREGATE" or "AGG" should now be only "Team Care" in any Sim UI, Demo, Team, Documentation. ALL instances of "SP" should now be only "Team Flow" (keeping the setting predecessor GMH/SMH/PC PCMHI as appropriate)

These changes are available on Dev environment.

Team Care image

Experiment image

Team Flow image

Note: For this development, it is recommended to avoid manual deployment & get support using Git CI-CD to facilitate the deployment of code into TEST & Prod environment as it involves changes at multiple locations.

matthewtomo commented 2 months ago

Discussed Friday Dev Standup wk_3 2024_09 @matthewtomo @tejaspesquare

matthewtomo commented 2 months ago

Discussed Monday Dev Standup wk_4 2024_09 @matthewtomo @tejaspesquare

matthewtomo commented 2 months ago
ljmoody commented 2 months ago

Discussed at wk4 2024_09 #9am_workflow @lzim @ljmoody @matthewtomo @dlkibbe

  • @ljmoody any thoughts on corrections for this paragraph? image
tejaspesquare commented 2 months ago

Hello Matthew,

  • Additional instances located when verifying that SDM-DOCs are up to date:

This has been manually updated at one location for the time being, as we have identified a static definition; however, it is essential to confirm whether this operates correctly with the CI-CD.

Furthermore, we identified similar occurrences throughout the document in various locations (count surpassing one thousand). We have not yet investigated the necessary actions required to replace each of them.

image image

matthewtomo commented 2 months ago

Hi @tejaspesquare, I think for now we decided that it was okay to leave the sp and agg in those SDM-DOCs, since we want them to be accurate to the "behind the scenes" filename. The above comment was more focused on documenting them and providing potential solutions to discuss in the #9am_workflow_meeting.

ljmoody commented 2 months ago

@ljmoody needs to remove from MTL 3.7 Consult Manual:

tejaspesquare commented 2 months ago

Hello Matthew,

  • Additional instances located when verifying that SDM-DOCs are up to date:

The document header name has been modified for following and is now accessible on the TEST environment.

Team Flow

image

Team Care

image

matthewtomo commented 2 months ago

@tejaspesquare I think that based on previous discussion we decided to keep the original filenames in the SDM-DOCs, since we want to make sure that it matches the name of the file we are actually using in our system.

Would we be able to revert that change?

Hi @tejaspesquare, I think for now we decided that it was okay to leave the sp and agg in those SDM-DOCs, since we want them to be accurate to the "behind the scenes" filename. The above comment was more focused on documenting them and providing potential solutions to discuss in the #9am_workflow_meeting.

matthewtomo commented 2 months ago

Discussed Friday Dev Standup wk_4 2024_09 @matthewtomo @tejaspesquare

@tejaspesquare I think that based on previous discussion we decided to keep the original filenames in the SDM-DOCs, since we want to make sure that it matches the name of the file we are actually using in our system.

Would we be able to revert that change?

Hi @tejaspesquare, I think for now we decided that it was okay to leave the sp and agg in those SDM-DOCs, since we want them to be accurate to the "behind the scenes" filename. The above comment was more focused on documenting them and providing potential solutions to discuss in the #9am_workflow_meeting.

fyi: @ljmoody

matthewtomo commented 1 month ago

Discussed Dev Standup wk_1 2024_10 @matthewtomo @tejaspesquare

fyi: @ljmoody


ℹ️: added this comment + link to #3202, dev/test flow tutor prompts

ljmoody commented 1 week ago

UPDATE 11/22/24: We will make these changes at a later date. A new card was created for Admin-facing AGG & SP changes to make - #3321


@matthewtomo, is it relevant to also change the following for what Admin users view in the Tutor Admin Dash? (I don't remember if we discussed this already.)

image

And another level down (example): image

ljmoody commented 1 week ago

@matthewtomo, following up on unchecked items on this card.

ljmoody commented 6 days ago

@lzim, looking for your direction in this comment above regarding changing Team Care to "TC" and Team Flow to "TF" within the Experiment maintenance sidebar.

If you approve, I'd also like to propose the same change occur within the Tutor Administrative Dashboard: image

fyi @matthewtomo

lzim commented 6 days ago

If there is room I'd rather keep "Team Care" and "Team Flow" not use TC or TF.

The reason, beyond the fact that they have more characters than the 9 character (incl. space) "Team Care" and "Team Flow" do, is that many clinicians will more readily grasp the CC is short for "Care Coordination" and that MM is short for "Medication Management" and PSY is short for "Psychotherapy." Those are more likely to be abbreviations they may already use in clinical care.

In contrast, "Team Care" and "Team Flow" are short hands that have really more developed with MTL development, and are therefore less familiar and not as readily grasped without being spelled out.

ljmoody commented 6 days ago

@lzim, your explanation helps my understanding of your response - thank you!

@matthewtomo. revised my comment above for renaming within the Tutor Admin Dashboard.

matthewtomo commented 5 days ago

is it relevant to also change the following for what Admin users view in the Tutor Admin Dash? (I don't remember if we discussed this already.)

Yes, but I'm thinking that this might be a good change to make later due to current scoping and how it will not be seen by outside users (only admins)

matthewtomo commented 5 days ago

Discussed Dev Standup wk_1 2024_10 @matthewtomo @tejaspesquare

@matthewtomo, following up on unchecked items on this card.

  • [ ] Change needed. Observed in TEST and PROD, fyi: image

  • [ ] @lzim @ljmoody are we certain we wish to remove the description of Team Flow from the above graphic? I thought we had already changed the label to be Team Flow + the description.

  • Are the MTL Module save names listed correct (i.e., no need to specify service choice for the modules with those)? Want to be sure before crossing off the last item in my Sept 19 comment above. Team Flow examples: image

  • @ljmoody experiments for Team Flow save all three of those services at the same time (because the Team Flow model uses all three). The labels for the diagrams are used to only show one at a time to the user and reduce complexity.

ljmoody commented 5 days ago

Yes, but I'm thinking that this might be a good change to make later due to current scoping and how it will not be seen by outside users (only admins)

Absolutely agree. I bundled it here because it's the same subject matter, but do agree it can/should be at a later date. I'll create a card (#3321) for those changes and update my comment above to include+link to that.