lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
9 stars 23 forks source link

SIM/UI Report Offset #465

Closed jamesmrollins closed 5 years ago

jamesmrollins commented 5 years ago

ORIGINATOR Please follow the steps below to open an issue for the MTL Workgroups to address. Be sure to provide a descriptive title for the issue when saving.

Step 1 - Please assign this issue to the issue_tracker, under the “Projects” menu on the right side of your GitHub page.

Step 2 - Please answer the questions below by placing a lowercase "x" between the applicable brackets below and providing brief narratives and screenshots where appropriate:

  1. Is this issue a problem, such as a malfunction in the simulation, an error in documentation or similar concern, or is this a new idea we should consider?

    • [ ] Problem
    • [x] New idea
  2. What team are you on (exg., Menlo Park, Team Blue)?

  3. How urgent is this issue?

    • [ ] Urgent - should be addressed right away!
    • [x] Non-urgent - can be prioritized within normal workstreams.
  4. In the space provided below, please describe the information or behavior you expected from the product or otherwise describe what you expected to see or hear.

  5. Please provide a screenshot of the bug, if possible. Make as many screenshots as you like that would be helpful to illustrate the issue.

    << Paste screenshots here>>

  6. Within which product did you notice the problem? Check all that apply

Data Products

Instructional Products

Simulations

Home

  1. What kind of device are you using?

    • [ ] Tablet
    • [ ] Smartphone
    • [ ] PC
  2. What browser were you using?

    • [ ] Chrome What version?
    • [ ] Edge What version?
    • [ ] Safari What version?

<< If you are highlighting a new idea, please continue >>

  1. Please describe your idea below. Feel free to provide a scan or screen capture of a sketch of your idea.

There is a new API we can apply to the SIM UI that will truncate the data file that returns simulation values. When we run the file from a negative time position, such as -1000 weeks, it creates a very large data file. Forio suspects this degrades the performance of the simulation, due to having to pass such a large file each time. The API would keep the values reached at time 0, and throw away the negative time values (they are not necessary to run the sim forward). Since the simulation only runs another 104 weeks, the data created by the run is relatively small compared to the 1000 week run to reach equilibrium.

  1. Why is this idea important, in terms of your work?

This should improve performance of the simulation.

  1. How is this idea related to a problem you face in your daily practice?

  2. Is there a deadline or other scheduled constraint driving your request that we should be aware of? This will help us to prioritize this request.

THANK YOU!!


STOP HERE. INFORMATION BELOW IS TO BE FILLED OUT BY WORKGROUPS AS PART OF TRIAGE AND WORK BREAKDOWN PROCESS

Executive Summary

Estimated person-hours to complete:

Estimated date for completion:

Lead team for effort:

Key people (use @ assignment for people whose input will be necessary):

Step 1 - Complete the Interdependencies Table

Workgroup Leads review information provided by originator and collaborate to identify interdependencies. Then they describe modifications that are needed in the appropriate column and estimate hours needed to make changes:

Workgroup Products - This column identifies the workgroups and the products for which they are responsible. This column can be modified by a workgroup lead on an ad-hoc basis to add one-time products or can be modified to include new and enduring products.

Dependency? - This column is used by the workgroup leads during collaboration to identify the existence of an interdependency.

Description of Change or Action Needed - Workgroup leads briefly describe the change required.

Hours - Workgroup leads estimate the person-hours required to complete the task.

Workgroup Products Dependency? Description of Change Needed Hours Estimate

Documentation
Brochures | | | MTL See Guide | | | MTL Say Guide | | | MTL Videos | | | Post Test | | | Investigators | | | Presentation | | | Quarterly Report | | | Annual Report | | | Qualitative | | | MTL Fidelity Checklists | | | Systems Thinking Codebook | | | CFIR Codebooks | | | Quantitative | | | Data UI | | | Data Queries | | | SharePoint | | | Excel Outputs | | | ModelParameters | | | tt Reports | | | Model CC | | | MM | | | PSY | | | AGG | | | SP | | | Sim User Interface | Y | The server instance of the model will be affected and the charts will not have the "Today" line any longer. Everything else the same. |16-20 hrs Model Diagram | | | "i"Information | | | Experiments | | | Outputs/Charts | | | Exports | | | Master Crosswalk Table | | |

Step 2 - Identify Constraints that may affect the team’s ability to complete the necessary actions.

Describe the constraint in terms of capability, capacity or affect on grant research goals. If there are no constraints identified, then leave the table blank.

● Type - The type of constraint identifies one or more resource areas that are affected.

● Workgroup - this is the workgroup responsible for developing a new or modifying an existing product.

● Discussion/recommendation - A brief narrative that expands the information regardingthe constraint and ideally a recommendation for overcoming the constraint.

Type Constraint (check all that apply) / Workgroup(s) Affected / Discussion/Recommendation

Step 3 - Identify supported milestones. Affix the milestone at the issue level using available GitHub milestones.

Step 4 - Indicate the due date for completing the actions identified above, assuming constraints are removed.

Step 5 - Identify the lead workgroup for the action (check one):

Step 6 - Go to the top of this section and complete Executive Summary information

Note to Workgroups: Use the issue thread to document further discussion, alternatives development and estimates. However, be sure to update this form if dates, team responsibility or other information changes.

jamesmrollins commented 5 years ago

@staceypark @jessfroe @TomRust @lzim @branscombj @saveth @holbrooa

When we implement the report_offset setting, there will not longer be negative time values. Ergo, there will be no need to have a "today" line in the charts. Further, no charts will display until the model runs, since there are no values to display. Is this ok with the group?

How it looks currently:

image

How it will look with report offset:

image

Initial anecdotal tests show SP running to equilibrium and displaying in 22 seconds and running to end in just over 12 seconds. There appears to be a pretty good performance improvement. More to follow.

jamesmrollins commented 5 years ago

@lzim Here is what the charts look like.

image