lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
15 stars 23 forks source link

2/14 Sim UI: Forio -> Gravatar is blocked #620

Closed lzim closed 4 years ago

lzim commented 5 years ago

1. Access to Gravatar shows resource is blocked:

I was unable to add a .jpg .png or .gif of the issue from my VA machine. There is an issue with posting screenshots on GitHub, that apparently began yesterday.

Instead, I've copied my Inspector > Console text below:

jquery-3.2.1.js:9455 [Deprecation] Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/. send @ jquery-3.2.1.js:9455 2gravatar.com/avatar/f7f3a78d2a2cf1645688acdb7f460138?&d=404:1

Failed to load resource: the server responded with a status of 503 (Service Unavailable) spplay.html:1

Access to XMLHttpRequest at 'https://gravatar.com/avatar/f7f3a78d2a2cf1645688acdb7f460138?&d=404' from origin 'https://forio.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.


Workgroups leads Identify Constraints (check all that apply):

Add estimated person-hours to complete: 35 DEV/ 2 PM phrs.

Edit the due date (if necessary)

jamesmrollins commented 5 years ago

@lzim Acknowledged. I will investigate ways for the Sim UI to re-interrogate the gravitar server, so that the image is eventually displayed. The error indicates a problem with their end, which does happen from time-to-time.

lzim commented 5 years ago

@lzim Acknowledged. I will investigate ways for the Sim UI to re-interrogate the gravitar server, so that the image is eventually displayed. The error indicates a problem with their end, which does happen from time-to-time.

Thanks @jamesmrollins!

Yes, this has happened intermittently since the beginning. But, it is becoming more frequent, which is why I opened the issue: 1) we do want to created updated .gifs and .jpgs with “presence” (i.e., with team member’s images), and 2) we also are getting ready to launch with frontline staff who will never meet some of us face-to-face.

jamesmrollins commented 5 years ago

@lzim @staceypark @jessfroe @ritahitching we implemented a bit of code that will re-attempt, although not indefinitely, to re-establish connection with the Gravatar server, if one isn't established during the initial loading of the web page. Please advise me right away, with appropriate console screen capture, if the Gravatar fails to load in the future. Thanks, James

lzim commented 5 years ago

@lzim @staceypark @jessfroe @ritahitching we implemented a bit of code that will re-attempt, although not indefinitely, to re-establish connection with the Gravatar server, if one isn't established during the initial loading of the web page. Please advise me right away, with appropriate console screen capture, if the Gravatar fails to load in the future. Thanks, James

staceypark commented 5 years ago

@jamesmrollins still failing to load. Sent you screenshot via email

jamesmrollins commented 5 years ago

@staceypark how long were you in the session? Based on the error code, the resource is not available at their end, or the domain is blocking it. I will run it past @hirenp-waferwire anyway, but suspect that is the issue. Our code should keep rechecking until it loads a Gravatar. That's why I need to know how long you had the window open.

@hirenp-waferwire see error from console below:

image

staceypark commented 5 years ago

@jamesmrollins at least 20min+ Does it recheck it in an indefinite loop or attempt x number of times? Although if it's blocked, checking an infinite number of times wouldn't really solve it....

jamesmrollins commented 5 years ago

@staceypark I discussed this with DEV. Bottom line is that it is a domain blocking issue. The fact that it checked even after 20 minutes means our code is working. I'm not sure I can do any more with this issue.

lzim commented 5 years ago

@staceypark I discussed this with DEV. Bottom line is that it is a domain blocking issue. The fact that it checked even after 20 minutes means our code is working. I'm not sure I can do any more with this issue.

@jamesmrollins and Forio has no other ways to get images in the Sim? Say at least for a known set of facilitators, even if not for all learners?

staceypark commented 5 years ago

@jamesmrollins is going to pursue a National helpdesk ticket first. Based on their response, we will re-evaluate by 10/15 on next steps.

jamesmrollins commented 5 years ago

@lzim FYSA

@jamesmrollins will investigate picture management alternatives that will:

  1. Provide a method for user-level upload of pictures.
  2. Maintain pictures from within Epicenter.
  3. Perhaps show facilitator picture to teams, and team pictures to facilitator.
staceypark commented 5 years ago

@jamesmrollins is holding off on the National helpdesk ticket for now.

jamesmrollins commented 5 years ago

@lzim @staceypark it is possible for us to manage photos in Epicenter by using the data API. We can also create an upload utility that so the user can choose and upload a photo, format it to the frame and save to the API. We will likely have to put this function on the button bar on the top of the screen. Between DEV and Design it will take about 20 hours with testing and configuration.

staceypark commented 5 years ago

@jamesmrollins has also proposed that we can use this with the team website from the facilitator dashboard end.

lzim commented 5 years ago

Thanks for your work on this @jamesmrollins !

it is possible for us to manage photos in Epicenter by using the data API. We can also create an upload utility that so the user can choose and upload a photo, format it to the frame and save to the API. We will likely have to put this function on the button bar on the top of the screen. Between DEV and Design it will take about 20 hours with testing and configuration.

  • Approved. use this with the team website from the facilitator dashboard end.
  • Great!

FYI: @staceypark

jamesmrollins commented 5 years ago

These design instructions were delivered via email to DEV on 10/22, since GITHUB was not accepting graphics.

Estimate: 20 Hrs for Items 1 and 2. Item 3 estimate pending Design Objectives:

  1. Install a button or link in the header of the Sim UI page header that will enable users to upload a picture.
  2. Install a utility that guides users through uploading a photo, centering the photo in a frame and then putting photo in the Sim Ui page header.
  3. Install same upload utility in the Team PSD website admin page. (let me know if this was not a part of original estimate – I don’t recall if we discussed this or not).

image

image

image

lzim commented 5 years ago

Thanks @jamesmrollins

FYI: @staceypark

jamesmrollins commented 5 years ago

Hi @lzim , @staceypark @ritahitching The estimate for item 3 is an additional 15 hours, for a total of 35 hrs DEV for this project. I will likely spend up to 2 hrs testing and administering the change. I have updated the estimate above.

lzim commented 5 years ago

Thanks @jamesmrollins

I am weighing the cost of 3 above with the cost and project breakdown in the pending Sim Tutorial #775 & participatory button #334, which also seem key for learners in the field.

Thoughts? @staceypark @jamesmrollins Maybe so, I welcome your recommendation based on how much the status quo for 3 costs. Thanks!

jamesmrollins commented 5 years ago

@lzim good question, and definitely a judgment call. If your goal is to preserve hours between now and April, so we can apply more towards the tutorial and the Go Live, I think we could safely put it in the future tracker.

With respect to the cost comparison, it generally takes just under an hour to format the photo, upload it and verify that it is centered properly. Much depends on the quality of the photo to begin with. If I get a good quality photo, it can take less time. So - we would probably face a maximum of 5 hours of PM time to manage you incoming team members.

lzim commented 5 years ago

Thanks @jamesmrollins

This is really helpful.

FYI: @staceypark

jamesmrollins commented 5 years ago

@lzim - WILCO

@hirenp-waferwire we are not going to install the photo upload to the Team PSD admin page at this time. We will likely include in a future release.

Thank you, James

jamesmrollins commented 5 years ago

Item 3 above has been split from this issue into #782

ritahitching commented 5 years ago

Should be ready to test later this week - @jamesmrollins will ask team members to upload their photos to test the process within the VA

jamesmrollins commented 5 years ago

Hi @hirenp-waferwire . This function is looking good. See below for some feedback.

This function is working well. image

Regarding the ability to manipulate the photo. image

jamesmrollins commented 5 years ago

@hirenp-waferwire please make the following changes:

image

jamesmrollins commented 5 years ago

Hi @lzim @staceypark @ritahitching @saveth @TomRust @branscombj @dlkibbe @dlounsbu take a look at this new photo upload feature! It works pretty slick. Just click the link shown highlighted below when you login to MTL, and upload your photo! Please let me know if you have any questions or concerns. Thank you, James

image

staceypark commented 5 years ago

@ritahitching @staceypark will test today

staceypark commented 5 years ago

@jamesmrollins works great! 😄

lzim commented 5 years ago

@staceypark @ritahitching and @jamesmrollins

Thanks!

ritahitching commented 5 years ago

@jamesmrollins tested it too, looks good

staceypark commented 4 years ago

Works great in Test, will leave open until it is moved and tested in PROD as well

staceypark commented 4 years ago

@jamesmrollins I noticed you cross-referenced this in #949 as a sub-item to be completed together by 2/14. I updated the due date to match.

staceypark commented 4 years ago

this works in PROD, is already documented in the sim_cheatsheet, will be cross-refed in the meta_document card for facilitator training and can be closed.