lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
15 stars 23 forks source link

9/20 - FRI Team 2 Meeting PSY Sankey: Basecase removed the majority of patients #709

Closed lzim closed 5 years ago

lzim commented 5 years ago

1. Add description:

@jamesmrollins We were prepping for Team 2 today and saw this below for a basecase run. Not sure what's causing this. Need to resolve and prep before Team 2's meeting Friday at 9:30AM Pacific. Sankey Issue

**NOTE: I was unable to upload the screenshot of the issue and console, so I also sent an email with the same name to your attention with @ritahitching and @staceypark

***NOTE: @jamesmrollins added screen capture for the record. @lzim was also using 640a)_team2_2019_08_01.xlsx team data file.

2. Click on the right: a. Projects - assign to issue_tracker. b. Assignee - assign relevant team members. c. Labels- review and select all potential MTL dependencies. d. Milestones - select the dependent milestone.


Workgroups leads Identify Constraints (check all that apply):

Add estimated person-hours to complete: 3 hrs.

Edit the due date (if necessary)

lzim commented 5 years ago

Adding @TomRust

jamesmrollins commented 5 years ago

@lzim FYSA

@TomRust I am not sure it is a model problem at this point. I will work with DEV tonight to verify that hypothesis. We have been having some issues with Forio APIs, so it may be related. I will advise more tomorrow.

@hirenp-waferwire please take a look at the way Sankey related variables are (not) loading. As you can see from comparing the two pictures below, the Vensim client version is returning, for example, EXP-A / ~240. But in the sim it returns no value [ ]. I have verified that we are running the same modelparameters file in both simulations. In the Model Directory in PROD it is called 640a0_team2_2019_08_01.xlsx - Thanks, James

Vensim

image

Sim UI image

Sankey Diagram (I would like to have a variable key for this diagram please) image

lzim commented 5 years ago

Thanks @jamesmrollins and @hirenp-waferwire! 🕵🏼‍♂️

@jwklocek and I will stay posted for an update 👀

ritahitching commented 5 years ago

@lzim @jamesmrollins will develop a map that will be added to the master to explain what variables drive which variables in the chart.

TomRust commented 5 years ago

I talked with James in our Support Leads meeting, and he has enough info now to work with the Dev Team to get this sorted. Should be squashed by the tomorrow morning (9/20).

jamesmrollins commented 5 years ago

@TomRust @lzim @staceypark I have tested this out in TEST and PROD this morning by comparing outputs to client Vensim model run with same ModelParameters.xlsx. The results of the SIM UI outputs and the Vensim model outputs are consistent and accurate. I promoted directly to PROD due to the urgency of the issue. Please report any issues with results to me right away. Thanks James

lzim commented 5 years ago

@TomRust @lzim @staceypark I have tested this out in TEST and PROD this morning by comparing outputs to client Vensim model run with same ModelParameters.xlsx. The results of the SIM UI outputs and the Vensim model outputs are consistent and accurate. I promoted directly to PROD due to the urgency of the issue. Please report any issues with results to me right away. Thanks James

Awesome, @jwklocek and I can test it out today, to make sure we’re ready for “Team 2” tomorrow 🦸🏻‍♀️🦸🏻‍♂️

lzim commented 5 years ago

@jwklocek

I tested the Team 2 PSY Basecase in my individual world, and it is as expected where the Sankey diagram for the Basecase, and the “Experiment” run correspond.

The issue we observed is also fixed in the team world, and their Q text from 8/30/2019: “How can we get more pts through a full course of quality PSY?” is displayed.

staceypark commented 5 years ago

@jamesmrollins @lzim is in the sim and we see Low/Medium/High for Engagement Duration levels. She recalls changing it to 25%/Median/75% at some point previously. Could you weigh in on what happened with these variable names?

lzim commented 5 years ago

@jamesmrollins

We were experimenting with changing Engagement Duration for patients engaged in care >3 mo (aka "cedtm") in the image below.

range_not_matching

lzim commented 5 years ago

@jamesmrollins @lzim is in the sim and we see Low/Medium/High for Engagement Duration levels. She recalls changing it to 25%/Median/75% at some point previously. Could you weigh in on what happened with these variable names?

More specifically, I could have sworn that when we were working on this last week, we saw "median" and "percentiles" for one variable (RVI or engagement duration) and "medium" and "low/high" for the other (RVI or engagement duration)

If this is not related to work on issue #709, then this question and my question above, likely should be separate issue cards that should go in the needs_triage column of the issue_tracker.

lzim commented 5 years ago

@jamesmrollins and @staceypark

Here: past_after

And here: diagram

🙄 These things are so annoying. Like the questions above, let me know how we should handle them: 1) in the context of the "closed" issue #709 in which they came up, or 2) in a new issue?

Thanks!

jamesmrollins commented 5 years ago

@lzim, let me check it out and I will get back with some recommendations. I'm sorry for the annoyance and will work hard to resolve.

lzim commented 5 years ago

Hey @jamesmrollins and @TomRust FYI: @staceypark

Is there a reason RVI wouldn't be in the outputs?

😍 SEARCH BOX that is such an upgrade! ❤️

jamesmrollins commented 5 years ago

@hirenp-waferwire please make the following changes in PSY:

Change slider name.

image

Change the slider icon name: image

Evaluate the variable scale values in the save function and revise: image

jamesmrollins commented 5 years ago

@lzim @staceypark @holbrooa @TomRust I investigated the Engagement Duration label issue, see https://github.com/lzim/teampsd/issues/451#issue-466013260, which is the PSY Team Data Table revision. There are no instructions changing "Low/Medium/High" to "25%/Median/75%." I also kind of rummaged around in my brain and didn't find anything either, but that isn't saying much 🤦‍♂️ . In any case, do you folks want me to change it?

jamesmrollins commented 5 years ago

@lzim @TomRust please see below. I looked over the model and found that the RVI is just a constant set at "0." I discuss the relationships in the diagram below. It appears not to be "reportable."

image

lzim commented 5 years ago

@jamesmrollins @TomRust and @staceypark

Hi 👋

I found a mix-up in two slider in PSY

Based on the output when I used the switch on the right, I believe the model is doing what is says.

@lzim @staceypark I investigated the Engagement Duration label issue, see #451 (comment), which is the PSY Team Data Table revision. There are no instructions changing "Low/Medium/High" to "25%/Median/75%." I also kind of rummaged around in my brain and didn't find anything either, but that isn't saying much 🤦‍♂️

@lzim @TomRust please see below. I looked over the model and found that the RVI is just a constant set at "0." I discuss the relationships in the diagram below. It appears not to be "reportable."

image

lzim commented 5 years ago

@lzim, let me check it out and I will get back with some recommendations. I'm sorry for the annoyance and will work hard to resolve.

...This stuff is a collective eye roll... 🤦‍♀ 🤦‍♂

...I'm so grateful for all you do to stay on top of this!

jamesmrollins commented 5 years ago

Hi @lzim @TomRust I am confused about your last entry, as I can't find "Initiators who Return Later %" neither in the Crosswalk nor in the model. However, I do find "Intiators who will Return." But it is measured in "pts" not "dmnl." Please clarify.

image

image

TomRust commented 5 years ago

@lzim The 9 RVI estimates for the cohorts in care >3 months aren't displayed in the model diagram, so we decided that they didn't need to be in the Expanded Outputs chart list either. Also, the RVIs are inputs to an experiment (and aren't affected by any other experiment), so I think it would be confusing to see any of them in an outputs chart. There wouldn't be anything interesting happening in those chart, anyway -- just a step change at week zero, as described in the i-text. As for outputs, we do have charts for the direct effect of these RVI changes = changes in the supply used by the different sub-cohorts of patients in care >3 months.

TomRust commented 5 years ago

@jamesmrollins -- that RVI variable (the one you describe as "hanging out") is only there so we can have i-text for a generic RVI variable in the model diagram. The model uses way more RVIs that we wanted to actually show in the diagram.

lzim commented 5 years ago

@jamesmrollins @TomRust

Thanks @jamesmrollins for this clarifying question. Yes, how these are supposed to be set up, is a bit confusing to me right now, too... I'm hoping @TomRust can help us, especially given your inability to find a dmnl "Initiators who Return Later %" as I would expect given the "i" text 🤓

There are the three outflows from the initiators stock and the starters stock

Based on what I'm reading the "i" information and believe we need this pair:

Then we need this pair

"i" text says these two pairs, should not sum to more than 100%, otherwise patients will be pursuing multiple engagement pathways simultaneously. (pct)

**This makes sense to me, but unfortunately, I can't help with your Vensim "missing" or "mismatched units" problem." Hopefully @TomRust can 💯

lzim commented 5 years ago

Thanks @TomRust

just a step change at week zero, as described in the i-text.

Okay this clarifies: I wondered because the "i" information calls this a "relative change," which commonly refers to differences in values observed over time. I want to be clear if someone asks about applying a typical "relative change" formula in this way related to the experiment timeline:

🧮 Training Team 2 example:

TomRust commented 5 years ago

@jamesmrollins -- yup. There is no separate "Initiators who Return %" variable. It is calculated from the other two relevant %s (i.e., the other two possible care pathways - quitting or continuing on in their first 3 months), and included directly in the "Initiation Rate who will Return." I can pop that part of the rate equation out into a new "Initiators who Return %" variable, if needed.

TomRust commented 5 years ago

@lzim -- RE: calculating the impact of a 75% reduction in >3month RVI for "Team 2"

Yup! That all makes perfect sense to me. Two quibbles: 1) I'd be a bit wary about assuming the average RVI is 5 weeks, though, as those three groups are probably not the same size. 2) Changing the RVI happens immediately at time zero...but only for appointments not yet booked! We aren't assuming that they re-book all the appointments already on the calendar to meet this new clinical goal, but that they apply it to all booking decisions going forward from time zero. This will delay the impact of this change (by the old RVI for each sub-cohort). You should see a staggered change in the Supply Used >3 months chart (e.g., first the completes will start being booked at the new RVI, as they only have 2 weeks worth of appointments on the calendar to get through, then the supply used by Initiators will increase after 4 weeks, etc.). At least until they run out of supply for this vastly increased demand for slots! :)

lzim commented 5 years ago

@tomrust

I'd be a bit wary about assuming the average RVI is 5 weeks, though, as those three groups are probably not the same size.

...only for appointments not already booked...

Very helpful clarification. Thanks!

lzim commented 5 years ago

Hey @jamesmrollins and @TomRust

Did these two switches get cleared up today? I do not see any updates about this since @jamesmrollins post yesterday afternoon saying he did not find the expected **dmnl “initiators who return later %” variable in Vensim.

I was busy all day with the Director job talk, so I’m just following up on it now.

Thanks, in advance, for the update!

Lindsey

@jamesmrollins @TomRust and @staceypark

Hi 👋

I found a mix-up in two slider in PSY

  • See in the screenshot how the two switches that are supposed to sum to 100 switch the stock they reference Starters plus Initiators on the left and Initiators plus Starters on the right. slider

Based on the output when I used the switch on the right, I believe the model is doing what is says.

  • It is setting the Initiators who Complete to 50% AND Starters who Return Later to 50%
  • What I need is Initiators who Complete to 50% AND Initiators who Return Later to 50%.
jamesmrollins commented 5 years ago

Hi @lzim , I hope you had a good director's talk today. We took care of the switch labeling issue regarding "after 3 Months" and the -75 to 200 drop down range issue last night. I was focused on the PsychTool and Chris today, so didn't follow up with @TomRust regarding the switch mix-up . I will reach out to him in the morning. Thanks, James

lzim commented 5 years ago

Great, thanks for the update @jamesmrollins!

I’ll be facilitating a training w/PSY at 9:30AM Pacific.

jamesmrollins commented 5 years ago

Hi @lzim . I just spoke with @TomRust and he indicates that indeed, the variable you seek does not exist; however, maintains that it was not essential to the story, since it was not something the team has direct control over. In any case, he will be at the Leads meeting tomorrow morning to discuss further. James

lzim commented 5 years ago

@TomRust and @jamesmrollins

Then, if these switches are meant to work the way they do, can we get the “i” information to match the labels of the switches, so the “story” and variables that actually exist to match then, please?

Based on what I'm reading the "i" information and believe we need this pair:

  • "Starters who Initiate %" with "Starters who Return Later %"

Then we need this pair

  • **Initiators who Complete %" with "Initiators who Return later %"

"i" text says these two pairs, should not sum to more than 100%, otherwise patients will be pursuing multiple engagement pathways simultaneously. (pct)

**This makes sense to me, but unfortunately, I can't help with your Vensim "missing" > or "mismatched units" problem." Hopefully @TomRust can 💯

I’m available via phone now, if you two are. 🤳🏼

lzim commented 5 years ago

Morning @jamesmrollins and @TomRust

@jamesmrollins it should be:

@TomRust is going to update the "i" information .xlsx on OSF and upload to the Sim UI.

NOTE: We will NOT be experimenting with this at today's training, but could be soon 📆

Thanks!

jamesmrollins commented 5 years ago

@lzim @TomRust I will issue a change order tonight to DEV and get this corrected by tomorrow. James

jamesmrollins commented 5 years ago

@lzim @TomRust please verify this is what you want. Then I will release. Thanks James

image

TomRust commented 5 years ago

@jamesmrollins , @lzim -- LZ and I talked this morning, and we decided that the itext was insufficient. I added this text (below) to the itext for these four slider variables in model pop-up table in OSF.

For the Starter sliders: Note, if these two percentages sum to 100%, that implies that no (zero percent) Starters are quitting early (i.e., the team has no "One-and-Dones").

For the Initiator sliders: Note, if these two percentages sum to 100%, that implies that no (zero percent) Initiators are returning later (i.e., completing there next appointment more than 3 months after they initiate).

lzim commented 5 years ago

Thanks to you both!

@jamesmrollins

sliders_psy

Make sense?

Thanks!

jamesmrollins commented 5 years ago

@hirenp-waferwire please make adjustments as indicated above.

lzim commented 5 years ago

@holbrooa

Among other things discussed, there’s a callout to you about use of low/medium/high for RVI and engagement duration in the thread above.

@holbrooa Can you help us to confirm?

holbrooa commented 5 years ago

Yes, the team data table clarifies this. It says:

"After the patients have been categorized by patterns of engagement, those who return for additional visits after three months are further categorized into low, medium, and high groups based on duration of engagement. The medium group comprises the middle 50%, with low and high comprising 25% each. The duration values are the 25th percentile, 50th percentile, and 75th percentile values taken from the entire group, and then the visit frequencies (RVI) are calculated from the median visit counts of each group."

The discussion about mean making something easier was something else.

jamesmrollins commented 5 years ago

@holbrooa and @lzim - so what is the call?

  1. Low/Medium/High or
  2. 25%/50%/75% or
  3. Low (25%ile)/Medium (50%ile)/High (75%ile).

BTW I looked up how to abbreviate percentile, and that is what Bing came back with - so it must be right 😉

lzim commented 5 years ago

@staceypark

Can you explain why @holbrooa found this answer in the Team Data but you did not?

@TomRust - If we send in the Vensim models with PSY manuscripts, we also need to make sure inaccuracies are caught (i.e., Vensim says “mean” when it’s the “middle 50 %”). We said we were post-poning some under the hood Vensim changes, previously. But, we may need to make sure we are current now.

@holbrooa

staceypark commented 5 years ago

@lzim not sure what you mean. That is what I said

Can you explain why @holbrooa found this answer in the Team Data but you did not?

@staceypark said the Team Data Table Definitions clarify whether that is the way these parameters are operationalized.

lzim commented 5 years ago

Apologies @staceypark I was remembering a meeting where I believe you weren’t clear about this answer, no?

If it’s all clear between team data and sim ui than we just need to get Vensim current and make sure what I proposed above for duration and rvi works for @holbrooa

lzim commented 5 years ago

@staceypark

Need to make sure these concepts are clear across dependent columns in the document_tracker

"low duration patients (median RVI in weeks), medium duration patients (median), high duration patients (median)"

holbrooa commented 5 years ago

Seems fine to me.

jamesmrollins commented 5 years ago

@lzim @holbrooa @staceypark Does this get the job done?

image

lzim commented 5 years ago

Yes, this looks good @jamesmrollins

What about the RVI and Engagement Duration charts?

Also, I want to keep this on @TomRust’s radar in terms of the Vensim models

jamesmrollins commented 5 years ago

@lzim - Thank you, I will review and add instructions.

@hirenp-waferwire - See changes below, thank you .

image

image

image

image

image

lzim commented 5 years ago

@jamesmrollins FYI: @staceypark

James, can you double-check that Team Data Table “i” information for “Engagement Duration” and “RVI” because it’s in the PSY module, but sounds like the two edits you have in the red call outs describe Care Coordination.