lzim / teampsd

Team PSD is using GitHub, R and RMarkdown as part of our free and open science workflow.
GNU General Public License v3.0
15 stars 23 forks source link

4/30 - MORE INFORMATION Page Redesign #886

Closed lzim closed 4 years ago

lzim commented 4 years ago

James,

I was closing out of my TEST session and I noticed how much sharper the “Select Team Data” section is than the other three image files here.

I know we’re working to get all the icons crisp, and I thought I would bring this one to your attention.

I believe you were going to see about uploading everything as vector (.svg) or something.

Thanks!

Lindsey





image

jamesmrollins commented 4 years ago

The screen captures can be loaded at a higher resolution. Not sure SVG will work in this circumstance since they are not drawings.

image

jamesmrollins commented 4 years ago

@lzim there are 22 of these bitmapped images in the FAQ. Will take roughly 3 hours for me to process the graphics into SVG and then roughly the same for DEV to place on the page and adjust for dynamic resolution.

staceypark commented 4 years ago

Below approved during Thurs 1/30 Support Workgroup meeting

@lzim there are 22 of these bitmapped images in the FAQ. Will take roughly 3 hours for me to process the graphics into SVG and then roughly the same for DEV to place on the page and adjust for dynamic resolution.

  • [ ] 3 Hours design time
  • [ ] 3 Hous DEV time
  • [ ] Release for DEV?
staceypark commented 4 years ago

@jamesmrollins I noticed you cross-referenced this in #949 as a sub-item to be completed together by 2/14. I updated the due date to match.

staceypark commented 4 years ago

We decide to gather requirements for this issue at the Thursday Support Workgroups Meeting.

jamesmrollins commented 4 years ago

Cross reference #989 Section is cut off.

lzim commented 4 years ago

@jamesmrollins

Do you still need existing meeting time to gather requirements for this? I added it to the release date section of "New Business" in tomorrow's workgroup leads meeting.

jamesmrollins commented 4 years ago

I also think we should consider adding an Admin page functionality to this page, so we can add sections and adjust content.

lzim commented 4 years ago

@jamesmrollins @staceypark

Cross-ref #339

From the meeting: https://meet.lucidmeetings.com/meeting/240523

Within the ? "MORE INFO" Icon of the Navigation Bar

  1. First Blue Bar the "MTL Road Map" - latest one is at mtl.how (may need another)
  2. Links should be separated from References and be the second blue bar.
  3. References blue bar will remain last in the list.
  4. ​​​​​Need instruction on how to expand the blue bars too - it's not obvious.
jamesmrollins commented 4 years ago

Design reviewed: [Adobe XD File] (https://xd.adobe.com/view/b7bd674a-fa80-47bd-79a9-9719965026dd-c18c/)]

Requirements Document: #885 more info page design rtvm.xlsx

Design Review #1 Checklist:

jamesmrollins commented 4 years ago

@lzim @staceypark Here is the revised drawing file with the changes we discussed yesterday. I plan to get this version costed out on Sunday night by DEV. Will be ready to receive a go decision by Monday if you are ready and have no further changes. Thanks, James

more_info_page copy.pdf

ritahitching commented 4 years ago

@jamesmrollins @lzim asked me to look over more_info_page copy.pdf Please see very minor comments below. Overall looks excellent. thanks

Comments

  1. Is there a way to make the information on the bullets fit into one line? I think it makes it easier to read.

Example 1: image

Example 2: image

  1. The icon looks out of sync with text on my screen.

    image

  2. The font in the small side box is too small for my eyes to read.

    image

Suggestions

  1. I wonder if learners would find the additional specificity helpful in the MTL.how Icon to say Click to access session guides

  2. In the MTL.how/videos icon to say Click to access the MTL Training Videos to differentiate from VAPOR?

  3. Do we want to add a logo and link to MTL.how's YouTube Channel?

  4. MTL.how/menu from what I understand the short-link takes users to VA RedCap. Should we add details about this? It currently takes users to Stanford RedCap.

  5. Suggestion to show options in pull down menus (e.g. MM Experiment 1 /2 and Waiting to Start). May help users see the different options.

    image

  6. Suggestion for References section: To learn more about the scientific literature about MTL and to download pdf files for free.....Zotero library.

    image

jamesmrollins commented 4 years ago

Hi @ritahitching , is this what you meant with respect to the comment about bullets? The italics are subheadings, so their needs to be some subordination. What do you think of the below?

image

lzim commented 4 years ago

@jamesmrollins

Modeling to Learn Guides

Modeling to Learn Links

_**Modeling to Learn Navigation**

Navigating the Home Screen

Modeling to Learn Modules

Bottom Navigation

Modeling to Learn Sections

Experiments

Model Diagram

jamesmrollins commented 4 years ago

@lzim @staceypark I don't think the single line rule for the "Modeling to Learn Module" section is a good idea. I think we underestimated just how long some of the Experiment Titles are (in one case, there was a line with 72 characters). Doubling up the longer lines is better visually, I think. I left the modules above the same for comparison. See below:

image

ritahitching commented 4 years ago

@jamesmrollins I was referring to the possibility of having the full description of an item within each bullet be in a single line - no wrap around of text, to look more elegant. I realize you need and are using italics as demarcation for subheadings - which is a fine choice. On my screen the font size in italics appears smaller, and when I read, my brain associates smaller text to indicate subordination more clearly than italics. Not a big issue at all. It was just my humble opinion 😄 .

Hi @ritahitching , is this what you meant with respect to the comment about bullets? The italics are subheadings, so their needs to be some subordination. What do you think of the below?

image

jamesmrollins commented 4 years ago

@ritahitching Thanks for the clarification. I don't have room for full descriptions, and have tried the single-line variable idea. But I don't think it will be workable with respect to column balance (see example above). I will experiment with increasing the size of the Italics, or just using normal text. I don't want to use boldface, as that is already used for H1. Thanks for your time reviewing this. James

lzim commented 4 years ago

@lzim @staceypark I don't think the single line rule for the "Modeling to Learn Module" section is a good idea. I think we underestimated just how long some of the Experiment Titles are (in one case, there was a line with 72 characters). Doubling up the longer lines is better visually, I think. I left the modules above the same for comparison. See below:

image

@jamesmrollins I substantially prefer the bottom example that

  1. Makes the experiments clear to read and look uniform
  2. Still includes a lot of what space
  3. Substantially reduces the length of the "More Info" page.
staceypark commented 4 years ago

@lzim @jamesmrollins Yes, I can agree that when the single line is 72 chars long it starts to look a bit silly. What's a good character stop then - 50?

jamesmrollins commented 4 years ago

@staceypark @lzim, I think 50 could work. Just something to balance out the columns a bit and match the title length of 4/5ths of the other lines. Yes, it would add about 10 more lines.

jamesmrollins commented 4 years ago

@lzim and @staceypark Here is a sample with Stacey's suggestion applied. Give me 25 or so more spaces to balance-out the columns. It only adds 6 more lines. I also adjusted the Aggregate line to show how it looks with shorter titles. Psych is the same for comparison. I think this is a good compromise.

image

lzim commented 4 years ago

886 - More Info > "Modeling to Learn" Sections Drop Down

lzim commented 4 years ago

@jamesmrollins and @lzim discussed this via teams today 4/20/20

Are you testing this @branscombj @dlkibbe ?

branscombj commented 4 years ago

@lzim No, I did not have testing this on my ⚫)))) radar (emoji improv). But can. is the idea that I should check it out in simUI TEST tomorrow and give feedback here?

@jamesmrollins @dlkibbe

jamesmrollins commented 4 years ago

Hi @branscombj - it is not available on TEST yet and is overdue. I am meeting with DEV tonight and will see where it is at. I will provide an update tonight. And thank you for volunteering to test - I will prepare the documentation. BTW, I love the radar emoji!

dlkibbe commented 4 years ago

@jamesmrollins @branscombj
Happy to test tomorrow late in the day or evening if its ready.

jamesmrollins commented 4 years ago

@dlkibbe @branscombj we should be ready for formal testing by tomorrow morning. I have a few glaring errors to fix on the Admin Page. I also need to populate the references and their associated hyperlink titles and URLs. The More Info page is in TEST if you want a peek.

jamesmrollins commented 4 years ago

Testing and Validation Document

Test/validate assignee: @branscombj @lrollins33 @dlkibbe

Test case document available here: https://github.com/lzim/teampsd/blob/quick_tips_webmaster/resources/training_guides/mtl_how_facilitate/mtl_more_info_webmaster/more_info_webmaster.md

Please check off these requirements as they are validated.

branscombj commented 4 years ago

MTL Guides Section

Recommend

Recommend

Top arrow in map is thinner than the others: image

The Community button lines show through the label "Click to expand" - Makes it look garbled. I recommend deleting that text in all the blue bars. Up/down triangles are pretty universally understood. image

branscombj commented 4 years ago

MTL Links section

Another reason to delete the "click to expand" verbiage - it says that even when you would click to minimize the open section: image

Should this be replaced with separate MTL Red and MTL Blue guides links? image

Consider replacing "**Internal for VHA providers only" with "(only accessible within VA)" or "(accessible behind VA firewall)" - because regardless of staff affiliation, those links won't work if you aren't behind the firewall. image

The mtl.how icon links properly, but all the others open a new window with "about:blank" in the search bar. I am not behind the VA firewall, so that might be what I'd expect to get for Data and Menu; but Live and Video should work.

lrollins33 commented 4 years ago

Broken links in the MTL References section of the MOREINFO page
@staceypark I don't have the resources to fix these. Who should be assigned to fix them?
Thanks
Lucy

Reference # Message
18 link to wrong paper
59 404 Page not Found
119 403 Forbidden
135 404 Error message, then takes you to https://case.edu/nursing/
149 404 Not Found
150 blank page
179 This site is not secure
181 takes you to Accords webpage; Zotero link not working either
lzim commented 4 years ago

Thanks for the review @branscombj

I approve this language change: "accessible behind VA firewall"

I agree with this logic: "because regardless of staff affiliation, those links won't work if you aren't behind the firewall."

lzim commented 4 years ago

Broken links in the MTL References section of the MOREINFO page @staceypark I don't have the resources to fix these. Who should be assigned to fix them? Thanks Lucy

Reference # Message 18 link to wrong paper 59 404 Page not Found 119 403 Forbidden 135 404 Error message, then takes you to https://case.edu/nursing/ 149 404 Not Found 150 blank page 179 This site is not secure 181 takes you to Accords webpage; Zotero link not working either

@ritahitching Can you help @lrollins33 find updated links for the 7 references?

@lrollins33 and @ritahitching - The Team PSD Zotero library should help answer this question.

jamesmrollins commented 4 years ago

Hi @lzim , I checked Zotero and found issues there too. I have a feeling these may have to be relinked by someone with access to stacks.

FYI @ritahitching @lrollins33

staceypark commented 4 years ago

Thanks @jamesmrollins. @ritahitching this should be in the "URL" section of the meta data for each reference in Zotero. Can you make sure both the link in Zotero is correct/updated and @lrollins33 has the links she needs as well?

Hi @lzim , I checked Zotero and found issues there too. I have a feeling these may have to be relinked by someone with access to stacks.

FYI @ritahitching @lrollins33

lzim commented 4 years ago

Hi @lzim , I checked Zotero and found issues there too. I have a feeling these may have to be relinked by someone with access to stacks.

@jamesmrollins I'm not sure what you mean by "stacks"

jamesmrollins commented 4 years ago

@lzim ye old library stacks. Meaning stacks of journals we used to dive into for research. Sorry for the archaic term.

ritahitching commented 4 years ago

@ritahitching this is a priority for Thursday 4/23 - will be needed by Friday for presentation.

dlkibbe commented 4 years ago

@jamesmrollins I've attached a review of the More Info content ment for your consideration. Take or leave as you see fit. More_info_page_copy review.docx @branscombj FYI

jamesmrollins commented 4 years ago

Thanks @dlkibbe ! I will process these tonight.

jamesmrollins commented 4 years ago

Hi @dlkibbe, after parsing through your feedback, I finally realized that you reviewed the design document, which was accepted and released into DEV last week. We are now making "small" adjustments to the web page in TEST ( https://forio.com/app/va/va-psd-test/moreinfo.html).

dlkibbe commented 4 years ago

@jamesmrollins @branscombj see feedback on the site noted in James' comment above.

Are we thinking that users will access more than 1 guide? I ask because of...:

  1. MTL Guides in green box - should be singular "Guide"? OK AS-IS
  2. Last bullet - should be singular guide in "Use the map to determine which guides you should use"? OK AS-IS

Use of asterisks in Accessible behind VA firewall - bold or italics suggested as asterisks suggest there is a footnote at the bottom of the screen RESOLVED**

Seems like the words "... the key is Modeling to Learn..." - should be bolded since the whole text is italicized to set them apart ON MTL HOME PAGE: Italicize "Modeling to Learn" in both places. No bold or whole paragraph bold. Exclamation point in plain text (not italics). Add comma in 2nd sentence after "Remember".

Bottom navigation - phrasing? "Click here to the community of practice supporting Modeling to Learn" Click here to join.... Click here to access... Click here to engage with... ADD THE WORD "join"

MTL Modules, Care Coordination - spelling correction needed: New Patients and Rererrals should be Referrals See heading under Experiment Variables

MTL Modules, Psychotherapy - General Question: Is use of the apostrophe in “Patient’s” correct? In the text “Change in RVI of Patient’s Past 3 Months” and “Change in Engagement Duration of Patient’s Past 3 Months.” Patient’s – one patient has something vs. Patients’ many patients have something; isn't the model referring to a group of patients? In the “i” in the PSY module we use “Patient’s” in the title but the description says, “This is a relative change in patients' return-to-clinic visit interval after their first three months in psychotherapy.”

MTL Modules, Aggregate -

  1. Descriptive text: "...affect your overall mix of services..." - should this be "...affect your clinic's overall mix of services..."
  2. List of Experiment Variables, last bullet needs "i" removed and hyphen inserted to be "Short-Term": Sensitivity of Staff Missed Appointments Due to Shorti Term Overtime

MTL Modules, SP -

  1. Descriptive text: should the risk be plural "risks" in the phrase? Seems like there are symptoms and risks.: "This model shows the effects of measurement based stepped care on patients' symptoms and risk."
  2. First bullet under Experiment Variables has spaces between the semi-colons and the text. The other bullets do not.

MTL Sections, Play Screen – instead of “This screen…” perhaps the text should say “A model diagram screen specific to your module will load after clicking “Play” on the Sim UI home screen.” People may expect to see the actual screen image shown below the text.

MTL Sections, Text - spelling correction - receive in "Click the Tutor to recieve helpful prompts about the section."

MTL Sections, Experiments -

  1. spelling correction - adjustable in "The Experiments section includes the Team Data Table and adjustible experiment sliders." DONE
  2. Spelling correction - retrieved in “The Team Data Table lists your team’s data retreived from the Corporate Data Warehouse.” STILL NEEDED

MTL Sections, Model Diagram - Experiment Slider Icon doesn't need to be capitalized in "This Experiment Slider Icon has a corresponding slider in the Experiments section."

branscombj commented 4 years ago

Follow-up on @dlkibbe 's notes:

Are we thinking that users will access more than 1 guide? I ask because of...: MTL Guides in green box - should be singular "Guide"? Last bullet - should be singular guide in "Use the map to determine which guides you should use"?

Plural is correct here because this is directing learners to which set of guides is appropriate for them, depending on whether they are in Red, Blue, or self-learning via Video.

Use of asterisks in **Accessible behind VA firewall - bold or italics suggested as asterisks suggest there is a footnote at the bottom of the screen

We just decided on some different wording (see above approval by LZ) so the asterisks will go away.

jamesmrollins commented 4 years ago

@dlkibbe @branscombj See below. The checks indicate I have either made the edit or the change is reflected in tonight's bug report. I will discuss unchecked issues with @lzim in the Sim UI meeting later this morning.

- jmr note: This will require a change to all Home Screen verbiages. - jmb note: The ACTUAL homepage edits I suggest above are not essential. The only typo is the bold exclamation point. The only style issue is the lack of italicization for Modeling to Learn. The IMAGE of the Homepage that appears on the More Info page does show all the text italicized. To me that's no big deal for that page - and also would be an ok way to show it on the Home Page.

jb note: It's complicated because the 3 months we're talking about are each patient's own first 3 months in care. I think wherever it says "Patients Past 3 Months" it means number or group of patients who are in care after their own first three months - so in these cases, there should be no apostrophe in Patients. And the apostrophe in the i information text (This is a relative change in patients' rvi after their first 3 months) is correct.

jb note: I agree. But would avoid "screen" - both at the top of the section and in the description. Would also leave off reference to clicking Play on the Home page because it loads when you click Play from any page. Recommend

ritahitching commented 4 years ago

@jamesmrollins I updated the Zotero library & More Info page for the references below.

Reference # More info Zotero
18 done done
59 done done
119 done done
135 done done
149 done done
150 done done
179 done done
181 done done

FYI @staceypark @lzim @lrollins33

staceypark commented 4 years ago

4/27 WG Leads meeting decision: @branscombj will close out review and finish checking off boxes

lrollins33 commented 4 years ago

@ritahitching I checked the links for the references 18, 59, 119, 135, 149, 150, 179 and 181 on the MORE INFORMATION page and they all are working properly.

branscombj commented 4 years ago

Hi @staceypark @jamesmrollins @dlkibbe @ritahitching @lijenn I apologize that I did not close this issue before the end of April. I had checked off all the validation boxes and didn't realize it was for me to make the card disappear:)

staceypark commented 4 years ago

Thanks @branscombj !

lzim commented 4 years ago

Thanks @branscombj !

Whoo hoo!! Yes, thanks Jane!