search

lzkelley / cosmopy

A simple cosmological calculator in python (API or command-line).
MIT License
8 stars 4 forks source link

Contributing cosmopy #3

Open camarman opened 1 year ago

camarman commented 1 year ago

Hello,

I would like to contribute to the project by any means (contributing to the README, code, etc.). Is the project still in development and is there will be a chance that my work/pull requests will be merged after review ?

Thanks

lzkelley commented 1 year ago

Hi Arman, the project is still active - in a fairly stable state. Are there particular features you think should be added or improved?

camarman commented 1 year ago

Thanks for the fast reply.

Hi Arman, the project is still active - in a fairly stable state.

That is great to hear.

Are there particular features you think should be added or improved?

I have not had a chance to look the code in detail...so I don't have any good ideas at the moment. But I'll look at it and get back to you, if it's okay.

camarman commented 1 year ago

Hello again,

I have looked at the code. It seems that only H0, Omega_b and Omega_m are defined for spatially flat LCDM model.

If that is the case, I can try to add radiation contribution or try to implement more general cosmological models, which are defined in the astropy. Maybe we can add the Planck18 data-set as the default (or optional) values for the cosmological parameters.

I can also try to create an online documentation. My English is not so perfect but I can try my best to help.

lzkelley commented 1 year ago

All of those ideas are great, thank you. Regarding the different cosmologies: adding radiation is a great place to start. It would also be good to generalize the code such that it could easily apply to any of the pre-build astropy cosmology classes. This might be doable with a "class factory" type approach, instead of manually implementing them. Let me know if you have any questions or issues with the code. Thank you for offering to help!

camarman commented 1 year ago

adding radiation is a great place to start

I tried to add it...Let me know if anything is wrong and I'll try to fix it.

It would also be good to generalize the code such that it could easily apply to any of the pre-build astropy cosmology classes. This might be doable with a "class factory" type approach, instead of manually implementing them.

Hmm. I don't know how to do class factory approach...but if you could show me a reference I might learn and try to implement it myself.

Let me know if you have any questions or issues with the code.

Thanks a lot. My python level is not so great. I am kind of a self-learner and some of the stuff in the repository is above my knowledge, but I can understand the module itself and make some changes to it.

Thank you for offering to help!

Your welcome! I hope I can help :)