search

lzybkr / TabExpansionPlusPlus

A V3 PowerShell module to improve tab expansion and Intellisense
BSD 2-Clause "Simplified" License
196 stars 33 forks source link

PsGet calls Install.ps1 if present #30

Closed flofreud closed 10 years ago

flofreud commented 10 years ago

By convention PsGet will call Install.ps1 if it is present. Therefore PsGet load an archive of TabExpansion++ and afterwards it execute Install.ps1 which override all the just downloaded files. This is no real problem, but unnecessary.

If you have a custom module-location and configure PsGet to install TabExpansion++ into it, the Install.ps1 will also install TabExpansion++ into the ~\Documents\WindowsPowerShell\Modules location.

Easiest solution would be renaming Install.ps1 in hope that no one use the script-link in automation.

edit Could be named GetTabExpansionPlusPlus.ps1

flofreud commented 10 years ago

I fixed the issue on the PsGet side by making the post-install-hook configurable and changed the configuration for TabExpansionPlusPlus to not execute the hook.

lzybkr commented 10 years ago

Thanks, I think that makes more sense anyway - it was a surprise to learn about this hidden PsGet feature.

flofreud commented 10 years ago

For instance posh-git is using the feature to add the necessary code to the user profile for the prompt modification. If you want to suppress the post-install-hook, you can use the -DoNotPostInstall flag now.

By the way, installation with PsGet is also possible with Install-Module TabExpansion++, because your fantastic module is in the PsGet directory.

Jaykul commented 10 years ago

Install scripts are run by nuget and chocolatey too -- it's the number one reason why I decided to write my own installer :-(

Joel "Jaykul" Bennett http://HuddledMasses.org http://PowerShellGroup.org

On Fri, Jul 25, 2014 at 10:33 AM, Florian Freudenberg < notifications@github.com> wrote:

For instance posh-git is using the feature to add the necessary code to the user profile for the prompt modification. If you want to suppress the post-install-hook, you can use the -DoNotPostInstall flag now.

By the way, installation with PsGet is also possible with Install-Module TabExpansion++, because your fantastic module is in the PsGet directory.

— Reply to this email directly or view it on GitHub https://github.com/lzybkr/TabExpansionPlusPlus/issues/30#issuecomment-50157400 .