lzybkr / TabExpansionPlusPlus

A V3 PowerShell module to improve tab expansion and Intellisense
BSD 2-Clause "Simplified" License
196 stars 33 forks source link

Ready for PowerShellGet? #31

Closed rkeithhill closed 8 years ago

rkeithhill commented 9 years ago

Just wondering if this module is ready to put on the PowerShell Gallery? When I first saw the Install-Module directions in the readme.md file I got excited but uh yeah, that's not the PowerShellGet Install-Module. :-(

lzybkr commented 9 years ago

It is actually in the gallery, it's just hidden. The actual module name is TabExpansion++, but that doesn't work with NuGet, so I had to publish the module name as TabExpansionPlusPlus.

It seems unlikely that NuGet/PowerShellGet will do anything to support '++' in a module name, so I probably should just publish as is.

On the other hand, I'm thinking of removing the attribute based registration as I don't think that's what will make it's way back into PowerShell.

Jaykul commented 9 years ago

Minimum Viable Product = ship what you got, fix it later ;-)

lzybkr commented 9 years ago

I'm not sure I get your point - names are sticky and removing functionality annoys people. But really, TabExpansion++ is already shipping via PSGet, so your point is moot.

powercode commented 9 years ago

When you say remove attribute based registration, do you mean the [ArgumentCompleter] functions?

If so, what would replace them?

lzybkr commented 9 years ago

Register-ArgumentCompleter (which is already present in TabExpansion++) or an attribute on the parameter, something like:

function Get-Process
{
    param(
        [Parameter()]
        [ArgumentCompleter([System.Management.Automation.ProcessNameCompleter])]
        [string[]]$Name
    )
}

This attribute will work best for cmdlets writing in C#, at least until V5 assuming the type ProcessNameCompleter could be implemented in PowerShell - but that will require inheritance and implementing an interface which isn't supported in V5 yet.

lzybkr commented 8 years ago

Closing old issues...