search

m-a-d-n-e-s-s / madness

Multiresolution Adaptive Numerical Environment for Scientific Simulation
GNU General Public License v2.0
182 stars 62 forks source link

relax Elemental specific version requirement (currently v0.84) #166

Open evaleev opened 9 years ago

evaleev commented 9 years ago

Can we relax the requirement to allow master Elemental?

justusc commented 9 years ago

I recall that the main barrier was that we were having issues with specific versions of Elemental giving in correct results. At the time, only 0.84 was working correctly. I think 0.85 was still under development at the time, but I am not 100% sure about that.

naromero77 commented 9 years ago

Yeah, we need at least version 0.84.

On Sunday, December 6, 2015, Justus Calvin notifications@github.com wrote:

I recall that the main barrier was that we were having issues with specific versions of Elemental giving in correct results. At the time, only 0.84 was working correctly. I think 0.85 was still under development at the time, but I am not 100% sure about that.

— Reply to this email directly or view it on GitHub https://github.com/m-a-d-n-e-s-s/madness/issues/166#issuecomment-162337028 .

Sent from Gmail Mobile

robertjharrison commented 9 years ago

In addition to correctness there were some API changes.

On Sun, Dec 6, 2015 at 2:28 PM, Nichols A. Romero notifications@github.com wrote:

Yeah, we need at least version 0.84.

On Sunday, December 6, 2015, Justus Calvin notifications@github.com wrote:

I recall that the main barrier was that we were having issues with specific versions of Elemental giving in correct results. At the time, only 0.84 was working correctly. I think 0.85 was still under development at the time, but I am not 100% sure about that.

— Reply to this email directly or view it on GitHub < https://github.com/m-a-d-n-e-s-s/madness/issues/166#issuecomment-162337028

.

Sent from Gmail Mobile

— Reply to this email directly or view it on GitHub https://github.com/m-a-d-n-e-s-s/madness/issues/166#issuecomment-162339740 .

Robert J. Harrison tel: 865-272-9262

poulson commented 9 years ago

I tend to respond to bug reports on master very quickly. I would suggest it at this point.

poulson commented 9 years ago

With that said, yes, there have been API changes (due to integrating much more sparse and convex functionality); it might be worthwhile to wait to update to 0.86 when it is released if you don't want to fiddle with ifdef's.

evaleev commented 8 years ago

ab55988bf9e17c2c41004010b65fad5ab7209fc6 added ability to pull and build arbitrary version of Elemental (cmake only!). Linear algebra has not been adjusted for API changes yet (hence will be disabled if non-embedded version of Elemental is used) but integration with world will still work.

poulson commented 8 years ago

Glad to hear it! Let me know if I can help ease any updates.