search

m-a-k-o / nova-custom-table-card

Simple Nova Card for Custom Tables
MIT License
46 stars 26 forks source link

Fix card overflow issue on 1/2 and 1/3 width #23

Closed shawngoh87 closed 3 years ago

shawngoh87 commented 3 years ago

@m-a-k-o On setting the width() of the cards to 1/2 or 1/3, Nova appends a card-panel class to the first <div>, which fixes the height to 150px, causing the table to overflow.

m-a-k-o commented 3 years ago

Hi , thanks for PR. Can me send overflow scenario ?

Why did you change w-full to 1/2?

shawngoh87 commented 3 years ago

I have reverted w-1/2 back to w-full in 425a4f66, that's a mistake.

I'll attach the screenshots and snippets later.

m-a-k-o commented 3 years ago

Thanks.

Maybe we can also omit css and use only h-auto instead.

shawngoh87 commented 3 years ago

Original issue - using width('1/2') image

After removing outer <div></div> image

shawngoh87 commented 3 years ago

Thanks.

Maybe we can also omit css and use only h-auto instead.

h-auto sounds cleaner, thanks for the suggestions, I'll add them in.

m-a-k-o commented 3 years ago

Perfect :) Thanks . I will merge and publish new version after ;)

m-a-k-o commented 3 years ago

@shawngoh87 Released as 3.0.1

m-a-k-o commented 3 years ago

Thank you for your contribution :)

shawngoh87 commented 3 years ago

Great! Thanks for your swift response 💯