m-ab-s / media-autobuild_suite

This Windows Batchscript helps setup a Mingw-w64 compiler environment for building ffmpeg and other media tools under Windows.
GNU General Public License v3.0
1.52k stars 263 forks source link

Error when running git update for libjxl #2120

Closed ycwan closed 2 years ago

ycwan commented 2 years ago
11:31:56   Running git update for libjxl...
11:32:06 ┌ libjxl git  .................................. [Updates found]
11:32:09 ├ Uninstalling asciidoc-py3-git... failed
11:32:23 ├ Running cmake...
11:32:32 ├ Running build...
Likely error (tail of the failed operation logfile):
  238 |     }
      |     ~
C:/MinGW-w64/build/libjxl-git/lib/jxl/enc_color_management.cc: In function 'jxl::Status jxl::N_SCALAR::DoColorSpaceTransform(void*, size_t, const float*, float*, size_t)':
C:/MinGW-w64/build/libjxl-git/lib/jxl/enc_color_management.cc:237:66: error: expected ';' before '}' token
  237 |       mutable_xform_src[x] = 100.f - 100.f * mutable_xform_src[x]
      |                                                                  ^
      |                                                                  ;
  238 |     }
      |     ~
ninja: build stopped: subcommand failed.
build failed. Check C:/MinGW-w64/build/libjxl-git/build-64bit/ab-suite.build.log
This is required for other packages, so this script will exit.
11:33:34   Creating diagnostics file...

All relevant logs have been anonymously uploaded to https://0x0.st/oXDo.zip
Copy and paste [logs.zip](https://0x0.st/oXDo.zip) in the GitHub issue.
Make sure the suite is up-to-date before reporting an issue. It might've been fixed already.
Try running the build again at a later time.

logs.zip ab-suite.build.log

GyanD commented 2 years ago

The automated build test for the change that introduced that code block passed.

https://github.com/libjxl/libjxl/runs/5138034602?check_suite_focus=true#step:5:73

1480c1 commented 2 years ago
#if JPEGXL_ENABLE_SKCMS
  if (t->channels_src == 1 && !t->skip_lcms) {
    // Expand from 1 to 3 channels, starting from the end in case
    // xform_src == t->buf_src.Row(thread).
    float* mutable_xform_src = t->buf_src.Row(thread);
    for (size_t i = 0; i < xsize; ++i) {
      const size_t x = xsize - i - 1;
      mutable_xform_src[x * 3] = mutable_xform_src[x * 3 + 1] =
          mutable_xform_src[x * 3 + 2] = xform_src[x];
    }
    xform_src = mutable_xform_src;
  }
#else
  if (t->channels_src == 4 && !t->skip_lcms) {
    // LCMS does CMYK in a weird way: 0 = white, 100 = max ink
    float* mutable_xform_src = t->buf_src.Row(thread);
    for (size_t x = 0; x < xsize * 4; ++x) {
      mutable_xform_src[x] = 100.f - 100.f * mutable_xform_src[x]
    }
    xform_src = mutable_xform_src;
  }
#endif

seems it might be because the CI might have JPEGXL_ENABLE_SKCMS defined

1480c1 commented 2 years ago

Possibly fixed in https://github.com/libjxl/libjxl/commit/7677d8beedab6f69b3552e578729ac2059df2311#diff-d5b654fcd4a0d86845d71558087b90abe16bdec3199a4d312af5a0a5df5b16d7R237, please try again

dolpsdw commented 2 years ago

To me its failing in C:/PORT/media-autobuild_suite/msys64/mingw64/include/c++/11.2.0/cstdlib:75:15: fatal error: stdlib.h: No such file or directory 75 | #include_next | ^~~~~~ compilation terminated.

https://0x0.st/o8EX.zip

ultrasound1372 commented 2 years ago

Also failing for me with stdlib, 32-bit build on x64 host. Are you also using a 32-bit build @dolpsdw? https://0x0.st/o8Rw.zip

EraYaN commented 2 years ago

64-bit build also seems to fail with the stdlib.h not found error. Something is up with the build system.

1480c1 commented 2 years ago

So the original issue was fixed, but the next issue seems to be https://github.com/msys2/MINGW-packages/issues/10761

1480c1 commented 2 years ago

Closing in favor of https://github.com/m-ab-s/media-autobuild_suite/issues/2136 since this issue is technically closed