mingw64 vvc: GCC 13.1 requires '#include <cstdint>' in TypeDef.h

LigH-de commented 1 year ago

In file included from G:/MABS/build/vvc-git/source/Lib/CommonLib/CommonDef.h:65,
                 from G:/MABS/build/vvc-git/source/Lib/CommonLib/AdaptiveLoopFilter.h:41,
                 from G:/MABS/build/vvc-git/source/Lib/CommonLib/AdaptiveLoopFilter.cpp:38:
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:253:15: error: 'int16_t' does not name a type
  253 | typedef       int16_t           Pel;               ///< pixel type
      |               ^~~~~~~
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:54:1: note: 'int16_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   53 | #include "CommonDef.h"
  +++ |+#include <cstdint>
   54 | 
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:255:15: error: 'int16_t' does not name a type
  255 | typedef       int16_t           TMatrixCoeff;      ///< transform matrix coefficient
      |               ^~~~~~~
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:255:15: note: 'int16_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:256:15: error: 'int16_t' does not name a type
  256 | typedef       int16_t           TFilterCoeff;      ///< filter coefficient
      |               ^~~~~~~
G:/MABS/build/vvc-git/source/Lib/CommonLib/TypeDef.h:256:15: note: 'int16_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
{...}

LigH-de commented 1 year ago

In the meantime... build/vvc_extra.sh

_pre_ninja() {
    sed -i 's!#include <cstdlib>!#include <cstdlib>\n#include <cstdint>!' ${REPO_DIR}/source/Lib/CommonLib/CommonDef.h
    sed -i 's!#include <cstddef>!#include <cstddef>\n#include <cstdint>!' ${REPO_DIR}/source/Lib/CommonLib/TypeDef.h
    sed -i 's!#include <cstdarg>!#include <cstdarg>\n#include <cstdint>!' ${REPO_DIR}/source/Lib/CommonLib/dtrace.h
    sed -i 's!#include <vector>!#include <cstdint>\n#include <vector>!' ${REPO_DIR}/source/Lib/CommonLib/Hash.h
    sed -i 's!#include <vector>!#include <cstdint>\n#include <vector>!' ${REPO_DIR}/source/Lib/Utilities/program_options_lite.h
}

hydra3333 commented 1 year ago

thank you

LigH-de commented 1 year ago

Nobody reminded me that the repo above is a local fork for the m-ab-s project...

Reported to Fraunhofer VVC trac, ticket 1600.

LigH-de commented 1 year ago

1 week without any reaction upstream. Is this project abandoned?

1480c1 commented 1 year ago

If you're talking about mabs, rn on a vacation right after graduation. If about vvc, idk, all I know is that I've heard more activity on vvenc and and vvdec more often.

On Fri, May 26, 2023 at 15:31 LigH @.***> wrote:

1 week without any reaction upstream. Is this project abandoned?

— Reply to this email directly, view it on GitHub https://github.com/m-ab-s/media-autobuild_suite/issues/2436#issuecomment-1564837035, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7VPRWNJWONKHWXC2QS5DTXIEAJHANCNFSM6AAAAAAYBBRRQY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

LigH-de commented 1 year ago

No, I mean Fraunhofer VVC VTM. New "blocker" grade ticket should either be taken serious or degraded.

OK, got a reply there.

LigH-de commented 1 year ago

A fix has been committed. Works again.

m-ab-s / media-autobuild_suite

mingw64 vvc: GCC 13.1 requires '#include <cstdint>' in TypeDef.h #2436