m-ab-s / media-autobuild_suite

This Windows Batchscript helps setup a Mingw-w64 compiler environment for building ffmpeg and other media tools under Windows.
GNU General Public License v3.0
1.53k stars 264 forks source link

glslang fails #2567

Closed Fishman0919 closed 8 months ago

Fishman0919 commented 9 months ago

11:59:39 Running git clone for glslang... 11:59:57 Running git update for glslang... 11:59:58 ┌ glslang git .............................. [Recently updated] 11:59:58 ├ Installing python... done 12:00:00 ├ Running dependencies... 12:00:13 ├ Running cmake... 12:00:15 ├ Running build... Likely error (tail of the failed operation logfile): 263 | }; | ^ C:/MAS/msys64/mingw64/include/c++/13.2.0/tuple:2005:45: note: candidate: 'template<class _Tp, long long unsigned int _Nm> array(std::array<_Tp, _Nm>)-> std::array<_Tp, _Nm>' 2005 | template<typename _Tp, size_t _Nm> struct array; | ^~~~~ C:/MAS/msys64/mingw64/include/c++/13.2.0/tuple:2005:45: note: template argument deduction/substitution failed: C:/MAS/build/glslang-git/glslang/MachineIndependent/Initialize.cpp:263:1: note: 'glslang::{anonymous}::BuiltInFunction' is not derived from 'std::array<_Tp, _Nm>' 263 | }; | ^ ninja: build stopped: subcommand failed. build failed. Check C:/MAS/build/glslang-git/build-64bit/ab-suite.build.log This is required for other packages, so this script will exit. 12:01:37 Creating diagnostics file...

Attach C:\MAS\build\logs.zip to the GitHub issue. logs.zip

doehrm commented 9 months ago

The upstream changes from this commit seem to have caused this:

https://github.com/KhronosGroup/glslang/commit/0ae8960087182fbda997a04aca130ec2d7720b66

Is there an easy way of un-patching just this commit?

doehrm commented 9 months ago

seems to be fixed by https://github.com/m-ab-s/media-autobuild_suite/commit/56bc538a941134f68a436dd79e8301db5d18c516

1480c1 commented 8 months ago

https://github.com/KhronosGroup/glslang/commit/809fd43ed62d0b3b7827fcd6913db03588f58b08