m-ab-s / media-autobuild_suite

This Windows Batchscript helps setup a Mingw-w64 compiler environment for building ffmpeg and other media tools under Windows.
GNU General Public License v3.0
1.49k stars 257 forks source link

Function calls not updated after signature change in libavcodec\libjxldec.c #2588

Closed a-j-albert closed 5 months ago

a-j-albert commented 5 months ago

In libjxl-git\CHANGELOG.md there's a line:

Those functions are called in libjxldec.c under conditional compilation. For each use, one case was changed to fit the new signature, but not the alternate one. E.g., line 216:

if JPEGXL_NUMERIC_VERSION < JPEGXL_COMPUTE_NUMERIC_VERSION(0, 9, 0)

jret = JxlDecoderGetICCProfileSize(ctx->decoder, &ctx->jxl_pixfmt, JXL_COLOR_PROFILE_TARGET_DATA, &icc_len);

else

jret = JxlDecoderGetICCProfileSize(ctx->decoder, JXL_COLOR_PROFILE_TARGET_DATA, &icc_len);

endif

The first case above has the now unused argument &ctx->jxl_pixfmt, which causes the build to fail. (Also see lines 267, 276 and 227

I'm not sure why my build hits that case.

a-j-albert commented 5 months ago

ab-suite.make.log

a-j-albert commented 5 months ago

I didn't mean to close it.

1480c1 commented 5 months ago

Should be closed with https://github.com/libjxl/libjxl/pull/3184