m-ab-s / media-autobuild_suite

This Windows Batchscript helps setup a Mingw-w64 compiler environment for building ffmpeg and other media tools under Windows.
GNU General Public License v3.0
1.49k stars 257 forks source link

newly revised release of Vapoursynth R66 #2618

Closed hydra3333 closed 2 months ago

hydra3333 commented 3 months ago

OK, the newly revised release of Vapoursynth R66 works, after some initial tests. The assets in the github R66 release have been updated in-place to ensure portable installation is more "local".

There's a possible caveat on the portable install via the file Install-Portable-VapourSynth-RXX.ps1 though; it installs into a slightly different place than the documentation suggests depending on how you read it - any scripts you may have could need to be changed unless you tell R66 to install in the place you want. Reference: https://github.com/vapoursynth/vapoursynth/issues/1037

Would it be possible to update MABS to use vapoursynth R66 ?

Thanks

1480c1 commented 3 months ago

once my laptop gets back from repairs, I will try to take a look at it

On Thu, Mar 14, 2024 at 1:53 AM hydra3333 @.***> wrote:

OK, the newly revised release of Vapoursynth R66 works, after some initial tests. The assets in the github R66 release have been updated in-place to ensure portable installation is more "local".

There's a possible caveat on the portable install via the file Install-Portable-VapourSynth-RXX.ps1 though; it installs into a slightly different place than the documentation suggests depending on how you read it - any scripts you may have could need to be changed unless you tell R66 to install in the place you want. Reference: vapoursynth/vapoursynth#1037 https://github.com/vapoursynth/vapoursynth/issues/1037

Would it be possible to update MABS to use vapoursynth R66 ?

Thanks

— Reply to this email directly, view it on GitHub https://github.com/m-ab-s/media-autobuild_suite/issues/2618, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7VPRTZGRS7DAZXLSWMBITYYFCPPAVCNFSM6AAAAABEVQDKPGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4DKNJXGAYDEMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

L4cache commented 3 months ago

I bet you can just unzip the wheel file and place the .dll and .pyd file in the old place and call it a day

hydra3333 commented 3 months ago

I bet you can just unzip the wheel file and place the .dll and .pyd file in the old place and call it a day

um, different subfolder names for a start (if you are installing for real) ...

L4cache commented 3 months ago

um, different subfolder names for a start (if you are installing for real) ...

Subfolders are different to older version, but I mean there should be no difference in the same current R66 version between install the wheel with pip and just unzip wheel (and move .dll .pyd files to proper location) based on my understanding.

Only plugins folders of portable changed, but the suite didn't install plugins. Although, if you are doing some serious stuff you might need pip to install some packages anyway... (Plugins, packages, that's probably what you mean "for real", I think.)

Besides, the dependency in build process is the sdk which is in the same place, so don't even need to unzip the wheel, well, I guess? The real problem would be change from 7z to zip because it's hardcoded in the script😂 but so does the VS version so just edit them toghther is fine.

L4cache commented 3 months ago

The alternative vapoursynth demuxer patch needs rebase/revise by the way, the struct names in libavformat/internal.h changed. https://github.com/FFmpeg/FFmpeg/commit/b800327f4c7233d09baca958121722a04c2035ff

hydra3333 commented 3 months ago

Wondering if it's possible to know whether the alternative demuxer is still applicable ? I guess since it's building for me now without the patch, I could save and test this version and then if and when the patch is rebased rebuild and test that. Unless someone else has already done it. Cheers

hydra3333 commented 3 months ago

Vapoursynth Portable now works great.

I built with MABS (updated to use R66) and nothing crashed during the build :)

Please feel free to update to R66.

    _python_ver=3.12.2
    _python_lib=python312
    _vsver=66
elif do_wget "https://github.com/vapoursynth/vapoursynth/releases/download/R$_vsver/VapourSynth${bits%bit}-Portable-
R$_vsver.zip"; then
1480c1 commented 2 months ago

https://github.com/m-ab-s/media-autobuild_suite/commit/2cab2de652535fd0191eaa4405862c96cb15275c