Closed Selur closed 1 month ago
The message "No default whitelist set" is present in works properly sample as well. So what actually happened is more than that, I did very simple (skill issues) debug by opening crash dump with windbg and found some thing related to INVALID_POINTER_READ_c0000005 or gme_open_data, but generally I don't know what I'm doing.
And your properly working build is release build which is released 2023-12-31, I checked my old build by m-ab-s around that time and... it works as well. When testing gyan's 2024-03-28 git build which is currently the latest, it crashes as well. The problem is more likely in the library(ies) and its(their) integration with ffmpeg.
Possibly related?: https://github.com/shinchiro/mpv-winbuild-cmake/issues/633
Possibly related?: https://github.com/shinchiro/mpv-winbuild-cmake/issues/633
I don't think so, linking does work (also adding '-Wl,--allow-multiple-definition' doesn't help) Thanks for looking into it. (Happy to know that this is not something just on my setup,)
I found the crashes start to appear around the time that ffmpeg commit happens. I'm trying to apply the fix there (commit 6a9eefd) to somewhere in the suite to see if it helps.
This helps.
diff --git a/build/media-suite_compile.sh b/build/media-suite_compile.sh
index 94adc16c..4ed37e16 100644
--- a/build/media-suite_compile.sh
+++ b/build/media-suite_compile.sh
@@ -1327,7 +1327,7 @@ if { { [[ $ffmpeg != no ]] && enabled libbluray; } || ! mpv_disabled libbluray;
else
extracommands+=(--without-libxml2)
fi
- CFLAGS+=" $(enabled libxml2 && echo "-DLIBXML_STATIC")" \
+ CFLAGS+=" -Ddec_init=libbluray_dec_init $(enabled libxml2 && echo "-DLIBXML_STATIC")" \
do_separate_confmakeinstall --disable-{examples,doxygen-doc} \
--without-{fontconfig,freetype} "${extracommands[@]}"
do_checkIfExist
I applied the change, deleted my ffmpeg-git folder and ran the script. Sadly, that didn't fix the problem.
Deleting ffmpeg-git and libbluray-git and then running the script seems to do the job. :) hopefully this fix can be added to the script permanently.
Or wait a library that haven't been updated for a long time to update, why I have some kind of deja vu here?
Can you try again with https://github.com/m-ab-s/media-autobuild_suite/commit/e5f2dad3cd3734b0b6b3c45849fc2c20c190257f?
FFmpeg built this time :)
Found ffmpeg_extra.sh. Sourcing script... ├ Running pre vcs from ffmpeg_extra.sh... Running git clone for ffmpeg... Running git update for ffmpeg... ┌ ffmpeg git ......................................... [Recently updated] ├ Changing options to comply to nonfree... ├ Compiling static FFmpeg... ├ Running configure... ├ Running make... ├ Running install... ├ Stripping... └ ffmpeg-git .................................................. [Updated]
Using ffmpeg from gyanet, calling:
works properly, returning:
the call properly. Using ffmpeg build with MBAS, fails:
=> no clue what 'No default whitelist set' really means, but seems like it has to be set when building ffmpeg with libbluray. (I doubt this is related to using a different gcc version than gyanet)
In canse it helps, link to x264 BR-Demo and my ffmpeg_options.txt file.
Would be nice if this could be fixed. Thanks!
Cu Selur