search

m-ab-s / media-autobuild_suite

This Windows Batchscript helps setup a Mingw-w64 compiler environment for building ffmpeg and other media tools under Windows.
GNU General Public License v3.0
1.49k stars 257 forks source link

xavs2 compile err #2677

Closed mojie126 closed 1 month ago

mojie126 commented 1 month ago

微信截图_20240512233904 logs.zip

mojie126 commented 1 month ago

https://raw.githubusercontent.com/mojie126/ma/main/patch/xavs2/0001_xavs2_encoder_parameters.patch apply this patch, compile xavs2 success

LigH-de commented 1 month ago

Please do not close your issues before the suggested fixes are commited into the master branch. That creates the wrong impression that the issue got already fixed outside the suite and there are no more changes to be merged to the suite's batch or shell scripts. Instead, better create a "pull request".

Upstream fixes in the original projects are preferable, patches are just temporary solutions (unless the original project got abandoned).

PS: In your case, the patch is supposed to alter the sources of xavs2. This kind of "fix" is only suitable for the media-autobuild suite if an original project is abandoned; the maintainers would possibly even fork the original project, apply changes in their fork, and use that as repository in build/media-suite_deps.sh instead if there is no hope for the patch ever merged into the original project.

mojie126 commented 1 month ago

OK

LigH-de commented 1 month ago

So because it's not officially fixed yet, could you please reopen?

1480c1 commented 1 month ago

https://github.com/m-ab-s/media-autobuild_suite/commit/101faeaf7c615ec47af1645d1a0f341a7ec0b205