search

m-ab-s / media-autobuild_suite

This Windows Batchscript helps setup a Mingw-w64 compiler environment for building ffmpeg and other media tools under Windows.
GNU General Public License v3.0
1.49k stars 256 forks source link

[mingw64] [xavs2 git] #2680

Closed lopes143 closed 1 month ago

lopes143 commented 1 month ago 
...
libbluray git  .............................................. [Up-to-date]
xavs 0.1  ................................................... [Up-to-date]
  Running git update for xavs2...
┌ xavs2 git  .......................................... [Recently updated]
├ Running uninstall...
├ Running configure...
├ Running install...
Likely error (tail of the failed operation logfile):
      |                                             ^~~~
      |                                             |
      |                                             char **
C:/media-autobuild/build/xavs2-git/source/encoder/parameters.c:531:62: note: expected 'const char * const*' but argument is of type 'char **'
  531 | static char *xavs2_get_configs(int argc, const char * const *argv)
      |                                          ~~~~~~~~~~~~~~~~~~~~^~~~
C:/media-autobuild/build/xavs2-git/source/encoder/parameters.c:626:11: warning: unused variable 'map_index' [-Wunused-variable]
  626 |     int   map_index;
      |           ^~~~~~~~~
make: *** [Makefile:266: encoder/parameters.o] Error 1
install failed. Check C:/media-autobuild/build/xavs2-git/build/linux/ab-suite.install.log
This is required for other packages, so this script will exit.
  Creating diagnostics file...

Attach C:\media-autobuild\build\logs.zip to the GitHub issue.
Make sure the suite is up-to-date before reporting an issue. It might've been fixed already.

Try running the build again at a later time.

logs.zip

mojie126 commented 1 month ago

A temporary solution can solve the problem of compilation passing. Whether it can be repaired is awaiting official confirmation.

https://github.com/m-ab-s/media-autobuild_suite/issues/2677

lopes143 commented 1 month ago

I applied the patch, but when I run the build script again, it updates the xavs2 build to the no-patch version. I can't avoid it revering back to the bad version although I marked avs2 as "No" in the initial options.

parameters.c after patch and before script running parameters.c after patch and before script running

console log after applying patch and running again the script console log after applying patch and running again the script

parameters.c after running the script - revering the patch parameters.c after running the script - it keeps reverting the patch

mojie126 commented 1 month ago

Because ma will check git when compiling Add below this line

    do_vcs "$SOURCE_REPO_XAVS2"; then
    do_wget -c -r -q "https://raw.githubusercontent.com/mojie126/ma/main/patch/xavs2/0001_xavs2_encoder_parameters.patch" "0001_xavs2_encoder_parameters.patch"
    git apply "0001_xavs2_encoder_parameters.patch"
lopes143 commented 1 month ago

Thank you. It worked

piegit commented 1 month ago

Because ma will check git when compiling Add below this line

    do_vcs "$SOURCE_REPO_XAVS2"; then
    do_wget -c -r -q "https://raw.githubusercontent.com/mojie126/ma/main/patch/xavs2/0001_xavs2_encoder_parameters.patch" "0001_xavs2_encoder_parameters.patch"
    git apply "0001_xavs2_encoder_parameters.patch"

Where do I put the text?

lopes143 commented 1 week ago

Because ma will check git when compiling Add below this line

    do_vcs "$SOURCE_REPO_XAVS2"; then
    do_wget -c -r -q "https://raw.githubusercontent.com/mojie126/ma/main/patch/xavs2/0001_xavs2_encoder_parameters.patch" "0001_xavs2_encoder_parameters.patch"
    git apply "0001_xavs2_encoder_parameters.patch"

Where do I put the text?

I can't remember exactly because I had to redownload the suite, bit I think its on media-suite_compile.sh under the build folder. Find where's the first line and then add the other two down below