search

m-ab-s / media-autobuild_suite

This Windows Batchscript helps setup a Mingw-w64 compiler environment for building ffmpeg and other media tools under Windows.
GNU General Public License v3.0
1.56k stars 266 forks source link

Request: Check if OpenH264 can be updated #2799

Closed LigH-de closed 3 days ago

LigH-de commented 4 days ago

OpenH264 reports that MSYS2 ships newer headers, so the sources should possibly be updated:

├ Openh264 version differs from msys2's, current: 2.4.1, msys2: 2.5.0-1
├ Check if this is the latest suite and update if possible, else open an issue
woot000 commented 4 days ago

Have it updated as part of this pr

1480c1 commented 3 days ago

Closed with https://github.com/m-ab-s/media-autobuild_suite/pull/2798

L4cache commented 1 day ago

Doing manual updates doesn't look very optimal to me, what's the reason of it when we can just rely on pacman?

LigH-de commented 1 day ago

Once in a while it happens that an optional module in ffmpeg updates to an incompatible state, so the suite needs to "freeze" that module to a version which is still supported by ffmpeg until it develops to support that new API. At least I guess that this may have been the case here as well.

1480c1 commented 1 day ago

Doing manual updates doesn't look very optimal to me, what's the reason of it when we can just rely on pacman?

Specifically for OpenH264, mainly due to Cisco's licensing with h264 royalties stuff as far as I know. So the only way we can guarantee that you're covered by Cisco's agreement is to use Cisco's binaries. https://www.openh264.org/BINARY_LICENSE.txt

The reason we look at msys2's version is that Cisco doesn't distribute the headers alongside their binaries, so we instead rely on msys2 for that.