m-albert / fractal-ome-zarr-hcs-stitching

Fractal task(s) for registering and fusing OME-Zarr HCS using multiview-stitcher.
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

[WIP] Metadata & Fractal improvements #1

Closed jluethi closed 1 month ago

jluethi commented 2 months ago

This is a WIP PR with updates I've been working on for the fractal multiview stitcher task.

Issues I plan to tackle / have tackled:

Testing required:

Issues not tackled by this PR:

jluethi commented 2 months ago

To do before merge:

jluethi commented 2 months ago

@m-albert @nrepina I also updated the template now and set up the pre-commit configuration. I ran pre-commit once over the whole repo, fixes formatting issues that ruff didn't like and excluded a few ruff rules that seem a bit over the top to me. Let's try to make commits using pre-commit now (running pre-commit install in the repo once).

If you can't make sense of a pre-commit issue, you can always circumvent it by using git commit -m "my message" --no-verify

The repo is also set up to use tags for versioning. Once we merge this into main, let's tag that as version 0.0.1. Until we make the first tag, whl building will not work.

jluethi commented 2 months ago

@m-albert It's a bit of a messy PR as it touches many parts. But it's complete from my side now. All the open issues still listed above will be tackled elsewhere.

Do you want to have a look and merge when you're happy with it?

m-albert commented 1 month ago

@jluethi Thanks for all your work here. Your changes make sense to me and everything looks great 👍

Merging this PR and creating a tag as you suggested.