search

m-barthelemy / vapor-queues-fluent-driver

A Fluent implementation for https://github.com/vapor/queues (Vapor4)
MIT License
32 stars 16 forks source link

Fix error dequeuing job #22

Closed bottlehall closed 2 years ago

bottlehall commented 2 years ago

Issue #21 linked.

maximedegreve commented 2 years ago

This works 🎉

@m-barthelemy Could you merge this in for a new release?

m-barthelemy commented 2 years ago

I was having a little bit of trouble setting up my project using this package on my new M1 device. Making good progress now; will test, validate and then create a new release if all good. Since this changes the format of the jobs data, it will have to be a major release.

bottlehall commented 2 years ago

I’m not sure the existing version is useable with this error for on-demand jobs. So, could a major release be avoided as the underlying column is unchanged and any scheduled jobs’ data would be unaffected?

Sent from my iPhone

On 20 Feb 2022, at 04:58, Matthieu Barthélemy @.***> wrote:

 I was having a little bit of trouble setting up my project using this package on my new M1 device. Making good progress now; will test, validate and then create a new release if all good. Since this changes the format of the jobs data, it will have to be a major release.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

m-barthelemy commented 2 years ago

I’m not sure the existing version is useable with this error for on-demand jobs. So, could a major release be avoided as the underlying column is unchanged and any scheduled jobs’ data would be unaffected? …

It would be disruptive for people upgrading to the new release but that still have pending jobs: these won't be able to get read anymore.