search

m-bobrowicz / php-integrator-symbol-viewer

Atom package providing side panel with class information: constants, properties and methods with go-to functionality provided by php-integrator-base package.
GNU General Public License v3.0
20 stars 11 forks source link

remember when closed in all panes #29

Closed g13013 closed 8 years ago

g13013 commented 8 years ago

Thanks for this package

When I close the viewer and navigate to different files I expect it to be hidden until I open it again, so it would be great to keep the state (open/closed) during the session

m-bobrowicz commented 8 years ago

Indeed, you're right. that would be fixed in the next release (coming mid-April).

m-bobrowicz commented 8 years ago

Check out the new 0.6.0 version! I redesigned the hiding/showing (which is now collapsing actually). It is persisted on Atom closing, and should work when switching tabs.

Arcesilas commented 8 years ago

Hi,

This bug is still present when splitting panels: switch from left to right (for example) and the panel will show up even if it was hidden before...

Actually, here is what I've just tested:

  1. Split screen vertically.
  2. On left panel, open a file with symbols
  3. On right panel, open a file without symbols
  4. Hide symbol viewer panel when focus is on left panel
  5. Focus on left file (with symbols), then on right file (without symbols), and back to left: symbolw viewer panel will show up

Second situation, more strange:

  1. Split vertically
  2. Open 2 files with symbols
  3. Focus on left file, hide panel
  4. Focus on right file: panel hides automatically, display it
  5. Focus on left file: panel hides (it should be displayed)
  6. Focus on right file: panel hides (it should remain displayed)
  7. Focus on left file: panel shows up (it did not the first time, now it does and it should not)
Arcesilas commented 8 years ago

Some details: this strange behaviour happens when editing files from differents "Project folders".

When editing files in the same project, the panel stays hidden when focusing from one file to another when screen is splitted. The bug then occures in very special cases (but it's here...)