search

m-bobrowicz / php-integrator-symbol-viewer

Atom package providing side panel with class information: constants, properties and methods with go-to functionality provided by php-integrator-base package.
GNU General Public License v3.0
20 stars 11 forks source link

Panel dysfunction with files without classes #36

Closed Arcesilas closed 8 years ago

Arcesilas commented 8 years ago

Hi,

So I have all up to date (Atom 1.7.3 and all packages up to date).

When switching to a file with no class, the message "There is no data to be displayed" is displayed. Ok. When switching back to a file with a class, the message is still present, above the class symbols. When writing in a file with no symbols, when the panel updates, the message is added. So there can be 256 messages above symbols when switching back to a file with symbols. See capture:

multiple-messages

m-bobrowicz commented 8 years ago

This message is useless considering the latest UI changes, the panel should just remain collapsed (until functions are included in the list). I'll remove it in the next release.

Arcesilas commented 8 years ago

Thanks for your answer.

I know this message will be removed, but for now, it's very annoying. I've temporarily fixed this by setting container.innerHTML = ""; in EmptyFiguresView.js so that it stops bothering me like this: toomaymessages

:laughing:

neolao commented 8 years ago

Same here.

capture d ecran 2016-05-02 a 10 06 34

capture d ecran 2016-05-02 a 10 07 04

brianclogan commented 8 years ago

I fixed this in my pull request I just submitted.

Under EmptyFiguresView.js the line var container = document.createElement('atom-php-integrator-symbol-viewer'); needs to change to var container = document.createElement('atom-php-integrator-symbol-viewer-content');

m-bobrowicz commented 8 years ago

Fixed in 0.6.1.