search

m-bobrowicz / php-integrator-symbol-viewer

Atom package providing side panel with class information: constants, properties and methods with go-to functionality provided by php-integrator-base package.
GNU General Public License v3.0
20 stars 11 forks source link

Update required version of php-integrator-base #45

Open sebacruz opened 8 years ago

sebacruz commented 8 years ago

This change makes the package work again.

ricpelo commented 8 years ago

Related to issue #40 ?

sebacruz commented 8 years ago

Oh, yeah! I forgot to point that.

ricpelo commented 8 years ago

I'm totally newbie. What can I do in order to test it inside Atom?

ricpelo commented 8 years ago

Applying this patch, the package loads but the panel shows blank. DeprecationCop shows error messages about using deprecated calls. Using Atom 1.9.8.

sebacruz commented 8 years ago

You receive the same error with any file?

I was able to reproduce that error with some classes (like this) in Atom@1.9.8 with php-integrator-base@1.1.2 and find out that this package throws the following errors:

php-integrator-symbol-viewer/lib/Main.js:124

Uncaught (in promise) TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.

php-integrator-symbol-viewer/lib/ConstantDetailsView.js:10

Uncaught (in promise) TypeError: Cannot read property 'resolvedType' of undefined

I didn't have the time to debug a little bit more yet.

ricpelo commented 8 years ago

Thanks for your time, @sebacruz. I've reported the deprecation issue in #47.