search

m-byte918 / MultiOgarII

A continued version of the original MultiOgar, an open source Ogar server implementation written with Node.js.
Apache License 2.0
126 stars 131 forks source link

Spectating problems after first install #1479

Closed danny647 closed 5 years ago

danny647 commented 5 years ago

Hello. I've just installed Megabyte918/MultiOgar-Edited server and Luka967/Cigar client. It works except there are some minor issues that I can't figure out. I'm not a programmer but I hope someone can help me with these.

  1. if I connect to the server (and I'm alone there) and go straight to spectating the view is frozen. video 1

  2. if I start to spectate after I played (and I'm alone there) the view is shaking and jumps all over the place video 2

  3. if some of my cells goes out of filed of view they can becomes dead cells. mass is not shown anymore on those cells and they are not in center of view anymore. this doesn't happen in recombine mode where I can split over half of the map and view just adjusts and zooms out. video 3

I have these installed: nodejs: 8.12.0 npm: 6.4.1 figlet: 1.2.0 ws: 6.0.0 async-limite: 1.0.0

danny647 commented 5 years ago

I think i have tracked down the problem for the first issue. In file PlayerTracker.js in function updateSpecView() there is a division with zero and then the client gets NaN for coordinates. I added a line to check for division with zero and it seems to work. :P Does anyone have a server code without these problems and would be willing to share it? It took me 3 days to track down this problem :D Or am I missing something else? Maybe some additional packages from npm?

FirstCodeReviewer commented 5 years ago

Do a PR with your fix if its relevant to us.

BorysDev commented 5 years ago

Closing due to a lack of response from the OP.