search

m-byte918 / MultiOgarII

A continued version of the original MultiOgar, an open source Ogar server implementation written with Node.js.
Apache License 2.0
126 stars 131 forks source link

Fix safe spawning for viruses, mother cells, and players #1568

Closed joelsgp closed 3 years ago

joelsgp commented 3 years ago

Closes #1566

TopoR1 commented 3 years ago

bad fix

Tombez commented 3 years ago

Hey JMcB17, I appreciate the PR to fix the issue that you highlighted. I'm not going to merge it because it would cause the server to get stuck in an infinite while loop under certain conditions. One such condition is if the user increases the max cell size setting, then sets their mass really high, causing their cells to completely fill the map.

I'll soon fix the issue in a similar way as the solution you've proposed.

joelsgp commented 3 years ago

ppreciate the PR to fix the issue that you highlighted. I'm not going to merge it because it would cause the server to get stuck in an infinite while loop under certain conditions. One such condition is if the user increases the max cell size setting, then sets their mass really high, causing their cells to completely fill the map.

I'll soon fix the issue in a

Ok, sounds good 👍