Closed alokdhir closed 6 years ago
Thanks! This looks much better than #18. Remaining issues:
parseArgs()
simple. You don't need to change it at all. This function is only about parsing the user arguments, not about doing any actual work. For example, if there is an option that sets config.formInputStream
to something different than System.in
(e.g. a FileInputStream), that should be totally indepdenent of the fill_form
option.execute()
, and put the FDF-recognition code into a new function isFDF(BufferedInputStream inputStream)
.Note that it is sufficient to force-push your ammended commit to your branch. No need to open a new pull request. But do what's easiest for you. :-)
Thanks again for your effort! This is much appreciated.
@alokdhir This works great, thanks. Can you take into account @vog remarks so this can be merge?
For your information: @MSerrano0410 took over and added stamping support (see #21), with the goal of polishing up FDF support after stamping. Unfortunately, it seems he got stuck when he was almost finished.
Closing this for now. Feel free to open a new pull request if you want to contribute an improved patch!
Determine FDF vs XFDF by checking the first four bytes of input file.