Closed bkazula closed 3 years ago
Thanks a lot for your contribution! I like the idea, and the code looks quite good so far.
Here is the result of a quick review:
protocol
and ssl_protocol
is inconsistent and confusing, so:
default_ssl_protocol
, perhaps in a separate commit.ssl_protocol
for all parameter names.As soon as this pull request is finished, I'll publish a new release of requests_pkcs12
immediately.
Hey, thanks for the comments. I fixed all the points (sorry for the delay). Have a nice day! :)
Thanks for fixing, and thanks again for your contribution. I just released version 1.10
Hey, I needed support for a specific version of TLS (TLS1.2), with that PR everyone will be able to enforce the desired ssl protocol.