m-click / requests_pkcs12

Add PKCS#12 support to the Python requests library in a clean way, without monkey patching or temporary files
ISC License
124 stars 33 forks source link

Ability to enforce a specific version of TLS protocol #26

Closed bkazula closed 3 years ago

bkazula commented 3 years ago

Hey, I needed support for a specific version of TLS (TLS1.2), with that PR everyone will be able to enforce the desired ssl protocol.

vog commented 3 years ago

Thanks a lot for your contribution! I like the idea, and the code looks quite good so far.

Here is the result of a quick review:

As soon as this pull request is finished, I'll publish a new release of requests_pkcs12 immediately.

bkazula commented 3 years ago

Hey, thanks for the comments. I fixed all the points (sorry for the delay). Have a nice day! :)

vog commented 3 years ago

Thanks for fixing, and thanks again for your contribution. I just released version 1.10