search

m-click / requests_pkcs12

Add PKCS#12 support to the Python requests library in a clean way, without monkey patching or temporary files
ISC License
124 stars 33 forks source link

not_valid_after property is invoked as a method producing errors #29

Closed kyahehron closed 3 years ago

kyahehron commented 3 years ago

@vog I believe not_valid_after is a property that returns datetime.datetime object, not a callable?

line 37, in check_cert_not_after
   cert_not_after = cert.not_valid_after()
TypeError: 'datetime.datetime' object is not callable

Commit is from cb09e98

REF: https://github.com/pyca/cryptography/blob/87f43fb77e7f1c56471d3233a56000a51dc4a311/src/cryptography/x509/base.py#L118

vog commented 3 years ago

Thanks! I just fixed that and released it as version 1.12 on PyPI.

Does this solve it for you?

kyahehron commented 3 years ago

Unfortunately no, the commit brought another issue found here #30

vog commented 3 years ago

Closing this, as the problem at hand is solved. The other issue is discussed (and meanwhile solved) in #30.