search

m-czernek / acrobot

A simple acronym bot for Google Chat
Apache License 2.0
32 stars 7 forks source link

3 letter acronyms #15

Closed ctron closed 4 years ago

ctron commented 4 years ago

It looks like bot isn't getting triggered for 3 letter acronyms.

m-czernek commented 4 years ago

Hi,

thank you very much for your issue report. Can you be a bit more specific? What three letter acronym does Acrobot not respond to? A cursory testing in prod:

image

ctron commented 4 years ago

e.g. PNC:

image

m-czernek commented 4 years ago

Looks like intended behavior.

If you send a personal message to Acrobot (that means only you can see the communication, it's not in any room), Acrobot responds directly. So, the expected message is just PNC and the expected response is the explanation.

If you are in a room, Acrobot does not listen to all messages. You actively have to tag Acrobot and then, Acrobot has access only to your message and no other messages in the room. In a room, you have to send @Acrobot PNC and you get a response only when the @Acrobot is a link.

Does that make sense?

ctron commented 4 years ago

Hm, reviewing the chat logs: Indeed, every time the bot got asked directly.

Does that make sense?

Yes, it does :grinning: Sorry for the troubles.