Closed robmoss closed 4 days ago
I spotted one more potential typo in §5.2 of the demonstration notebook:
lhs_prcc
requires a pandas.DataFrame outlining the bombardiers of LHS (our parameter certainties)"; I suspect this should be "boundaries"?These typos have been dealt with.
Hi @m-d-grunnill, I noticed the following potential typos in the example notebook and the MetaCast package:
MultnomialSeeder
class is missing the "i" in "Multi"?metacast.event_handling
module provides anEventQueue
class, but "queue" is spelt "que" in several places, such as:metacast.event_handling.event_que
module (unlikely to be an issue, since theEventQueue
class is typically imported frommetacast.event_handling
)The last two should be simple to address, while correcting the first one would introduce a breaking change unless the class is exported under both the original and corrected names.
None of these are critical, and they do not detract from the value of the package, the examples presented in the notebook, or the JOSS paper. So please resolve these typos as you see fit, or not at all.