search

m-demare / hlargs.nvim

Highlight arguments' definitions and usages, using Treesitter
GNU General Public License v3.0
472 stars 10 forks source link

Compatibility with twilight.nvim #53

Closed MaazSiddiqi closed 1 year ago

MaazSiddiqi commented 1 year ago

Describe the bug What the bug is. If the issue is file/filetype specific, provide a file to reproduce it Args highlighted with this plugin seem to override the highlighting the twilight manages when enabled.

Expected behavior What you expected to happen. Args highlighted with this plugin should behave like the other dimmed syntax highlighted outside of the current twilight focus. Recreate it by having Twilight's focused region be near but outside or args that would normally be highlighted with Hlargs. It seems that they don't get dimmed despite all the other syntax highlighting being overridden with twilight.

Screenshots or sample file If applicable, add screenshots to help explain your problem.

Screen Shot 2022-12-15 at 4 32 28 PM Screen Shot 2022-12-15 at 4 44 14 PM

System information

Additional context Add any other context about the problem here. (this is my first opened issue ever, I apologize if I missed some more context)

m-demare commented 1 year ago

Hi! This seems to be a highlight priority issue. In hlargs, it is configurable using hlargs-config-hl_priority. It would look something like:

  require('hlargs').setup {
    hl_priority = 50,
  }

Please tell me if it is fixed using lower values

MaazSiddiqi commented 1 year ago

Hi! This seems to be a highlight priority issue

Oh yes! It was stupidly high in my config for some reason. Playing around with the value fixed the issue. Thank you!

m-demare commented 1 year ago

Great!