search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Modal Overlay Missing #101

Closed KreepN closed 9 years ago

KreepN commented 9 years ago

Copied the example you provided here on your codepen and updated most of the references to the most recent versions.

You'll notice that when you open the modal, the overlay is no longer present. Any idea on what may have changed to cause this?

It looks as though the overlay no longer has a height, but I'm not of why that would have changed.

KreepN commented 9 years ago

Seems the styles in the bootstrap.css file have changed:

.modal-backdrop is now 'position: absolute' and the 'bottom: 0' has been removed. If you manually add them back onto your page the overlay works again. I have added them to my linked codepen so that you can see the changes in action.

Not sure if that helps you adjust accordingly.

m-e-conroy commented 9 years ago

@KreepN I keep having to fix either the backdrop or the modal itself with showing up, its usually something to do with the Bootstrap CSS changing. I have CSS that accompanies the service but it may need updating to fix the specific Bootstrap change. Also you can add your own classes to the "window" or backdrop by using the options object and windowClass: 'my-class' or backdropClass: 'my-class' this may help fix or thwart future CSS changes.