m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

order of buttons in confirm dialog #103

Open Archelyst opened 9 years ago

Archelyst commented 9 years ago

I'm used to have the "OK" button on the very right of a dialog, the "cancel" on its left. Right now the template for the confirm dialogs is the other way round. Also the "cancel" button is highlighted (.btn-primary) which is really counterintuitive. I'd expect the highlighted button to trigger an action, not the regular restrained button.

m-e-conroy commented 9 years ago

I will take this into consideration. Not sure I want to highlight the OK button as primary seeing that if a person makes a mistake you don't want to be confirm the mistake as default. Hmmm, IDK, I'll think about it.

miszou commented 9 years ago

I also would like to at least exchange the styling to "yes" being the selected option (btn-primary) instead of the "no" option. As a decision aid I would suggest this link: http://www.nngroup.com/articles/ok-cancel-or-cancel-ok/

niemyjski commented 9 years ago

I think cancel should be the default. That way no harm can be done with those who are just hitting the enter key..