search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Default button label for Confirm Dialog not displaying correctly. #122

Open ywongweb opened 9 years ago

ywongweb commented 9 years ago

The default text for confirm dialog buttons are showing DIALOG_YES/DIALOG_NO instead of Yes/No. This problem first occurred in v5.1.0

http://codepen.io/anon/pen/KpQgEj

m-e-conroy commented 9 years ago

Try using Angular-Bootstrap 0.12 or 0.13, the pen you posted is using 0.11. Let me know if that fixes the problem - I haven't encountered this and I use the service on a daily basis. My current project uses Angular-Bootstrap 0.13.0 and the Angular-Dialog-Service 5.2.8.

ywongweb commented 9 years ago

I've made a plnkr with 0.13 and 5.2.8, it's still doing the same thing.

Changing the language to Spanish works as expected. Changing Angular-Dialog-Service back to v5.0.0 also works.

http://plnkr.co/edit/RLC1g0UGp9INxp4uHTLf?p=preview

cmcnamara87 commented 9 years ago

Having the same problem as @ywongweb

vmlf01 commented 8 years ago

I had to include the both 'dialogs.main' and 'dialogs.default-translations' to my module dependencies for it to pick up the translations.