search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Option for changing button text without replacing template #126

Closed dlwhiteman closed 6 years ago

dlwhiteman commented 9 years ago

Hi, it would be nice to be able to pass in options for the button text without having to replace the entire template for a dialog. For example, I would like to pass in options to replace the buttons for the confirm dialog to be whatever the action is that I am wanting to perform and Cancel. If I had "Reformat hard drive?" as my prompt message, it would be more clear if I could pass in "Reformat" and "Cancel" as the button text to replace the default Yes and No.

niemyjski commented 9 years ago

Do you want to create a pull request for this and we can talk about this more?

dlwhiteman commented 9 years ago

I'm sorry, I am new to the process of creating a pull request, etc. Does creating a pull request mean that I am making a commitment to implement the change? Please feel free to link me to any material that describes the process for Github projects. All of my Git work so far has been internal to my company. Thanks!

niemyjski commented 9 years ago

Not necessarily a commitment but it does get it implemented quicker if it's implemented and everyone likes it :). I don't really have any material other than forking it and then doing a pull request via github.com ( https://help.github.com/articles/fork-a-repo/)

dougmoscrop commented 9 years ago

In other words, @dlwhiteman - writing (at least some) code happens before the pull request is opened.

miszou commented 9 years ago

Isn't this a duplicate of #66 so therefore can be closed or at least referenced?

ckelley7 commented 7 years ago

Looks like we just need a couple more angular.dialogservice.IDialogOptions that can be used to override the YES and NO button text respectively.

mcaden commented 6 years ago

I've created a pull request for this feature. It's working in both the translate and the translate-substitution examples. I've also referenced #66 on the PR.

niemyjski commented 6 years ago

Thanks for the PR @mcaden . Can someone else here review the PR.

mcaden commented 6 years ago

I believe this can now be closed

niemyjski commented 6 years ago

Thanks!