search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

The bower main section Should use non minified version for correct wiredep behaviour #135

Open mhawila opened 9 years ago

mhawila commented 9 years ago

When using Grunt wiredep task to wire dependencies I notice the version I pulled from bower (version 5.2.8) had the main section specify the minified version (see below) contrary to "standard" practice. I had to override the property in my bower.json file for it to work properly.

"main": [ "dist/dialogs.min.css", "dist/dialogs.min.js", "dist/dialogs-default-translations.min.js" ],

Wouldn't it be nice to modity it to follow the conventions and become

"main": [ "dist/dialogs.css", "dist/dialogs.js", "dist/dialogs-default-translations.js" ],

dougmoscrop commented 8 years ago

I agree - for now you can override this in your own bower.json. I think we should make this a major version change since theoretically some peoples build pipeline might now be assuming that it is minified?