search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Updated npm and bower dependencies. Corrected license reference. Included bower_components into .gitignore file. #141

Closed dennybiasiolli closed 8 years ago

dougmoscrop commented 8 years ago

LGTM, @m-e-conroy I'm yet to use my merge permissions on this repo.. I would here, though I'm concerned that we don't have tests.

@dennybiasiolli have you manually tested this?

dennybiasiolli commented 8 years ago

@dougmoscrop not yet, I've only update dependencies and correct license and .gitignore.

m-e-conroy commented 8 years ago

@dougmoscrop I'll trust your judgement as my time is limited. Maybe someone can create some tests?

I'm with you though, this should be merged. Perhaps - merge it, the releases are still viable - the master branch will just be a work in progress... If someone has time for some tests, then we can create a new release later. What do you think?

dougmoscrop commented 8 years ago

I'll try to poke around a bit at it before I merge.

wcomartin commented 8 years ago

I'd be up for creating unit tests, anybody opposed to karma/jasmine?

also, i would like to setup a gulp watch task with a http connect server.

m-e-conroy commented 8 years ago

Go for it.

On Tue, Oct 13, 2015 at 4:55 PM, William Comartin notifications@github.com wrote:

I'd be up for creating unit tests, anybody opposed to karma/jasmine?

also, i would like to setup a gulp watch task with a http connect server.

— Reply to this email directly or view it on GitHub https://github.com/m-e-conroy/angular-dialog-service/pull/141#issuecomment-147850892 .

Michael E. Conroy michael.e.conroy@gmail.com

Blog: http://michaeleconroy.blogspot.com/ GitHub: https://github.com/m-e-conroy LinkedIn Profile https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

wcomartin commented 8 years ago

I've started creating tests in this repo https://github.com/wcomartin/angular-dialog-service/tree/UnitTests

I've also added a examples_live folder for the gulp-connect serving directory, because i didn't want to overwrite the current examples folder

m-e-conroy commented 8 years ago

Sounds good to me, I appreciate the help - especially since my time has been lacking lately.

On Tue, Oct 13, 2015 at 11:15 PM, William Comartin <notifications@github.com

wrote:

I've started creating tests in this repo https://github.com/wcomartin/angular-dialog-service/tree/UnitTests

I've also added a examples_live folder for the gulp-connect serving directory, because i didn't want to overwrite the current examples folder

— Reply to this email directly or view it on GitHub https://github.com/m-e-conroy/angular-dialog-service/pull/141#issuecomment-147915134 .

Michael E. Conroy michael.e.conroy@gmail.com

Blog: http://michaeleconroy.blogspot.com/ GitHub: https://github.com/m-e-conroy LinkedIn Profile https://www.linkedin.com/profile/view?id=260227&trk=nav_responsive_tab_profile

niemyjski commented 8 years ago

@wcomartin let me know when the tests are ready and I'll run them as well and merge it. Thanks again

niemyjski commented 8 years ago

@wcomartin any updates on this? Can you please merge in latest and resolve conflicts. We recently updated the dependencies.

niemyjski commented 8 years ago

closed via: https://github.com/m-e-conroy/angular-dialog-service/pull/168