search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Add support for ui-bootstrap 0.14+ #145

Closed NealHaggard closed 8 years ago

NealHaggard commented 8 years ago

They've renamed things including $modal to $uibModal (with 0.14.3 they will also rename $uibModalInstance). Currently it still works using angular-dialog-service 5.2.8, however a warning is given about $modal being deprecated when dialogs is initialized.

niemyjski commented 8 years ago

Can you please include a pull request for this. I can confirm this behavior.

NealHaggard commented 8 years ago

Added a pull request. https://github.com/m-e-conroy/angular-dialog-service/pull/146/files

niemyjski commented 8 years ago

@NealHaggard Thanks for your contribution!

niemyjski commented 8 years ago

Is anyone getting this error?

$modalInstance is now deprecated. Use $uibModalInstance instead.

NealHaggard commented 8 years ago

Have you upgraded your code after using this? dialog-service is now using ui-bootstrap 0.14.3 which will give those messages until you go change $modalInstance to $uibModalInstance (similarly $modal changed to $uibModal). I don't get this in my local usage of angular-dialog-service 5.2.9 with ui-bootstrap 0.14.3.

niemyjski commented 8 years ago

Yeah, I'm running latest of everything!

https://github.com/exceptionless/Exceptionless.ui

I need to check for usages but I'm about 95% sure I'm not injecting $modalInstance

NealHaggard commented 8 years ago

Just a quick look through your code found this:

https://github.com/exceptionless/Exceptionless.UI/blob/master/src/components/dialog/confirm-dialog-controller.js

niemyjski commented 8 years ago

Ah thanks :)