search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Updating to UI-Bootstrap 0.14.2, which includes renaming $modal to $uibModal #146

Closed NealHaggard closed 8 years ago

NealHaggard commented 8 years ago

Note that in 0.14.3, they will also be renaming $modalInstance to $uibModalInstance, so another change will need to be made when that is released. Solves m-e-conroy/angular-dialog-service/issues/145

NealHaggard commented 8 years ago

UI-Bootstrap 0.14.3 has been published, so updated to also rename $modalInstance to $uibModalInstance.

niemyjski commented 8 years ago

@m-e-conroy @NealHaggard does it make sense to even support 1.3 anymore? 1.4.7 is out and 1.5 is on the verge of release. Would be nice to update all the dependencies to 1.4.7 too.

NealHaggard commented 8 years ago

We just upgraded to 1.4.7 this week, we were previously following 1.3. Mainly because we haven't had breathing time to update. I'm not sure there are any issues with leaving support for Angular 1.3. My changes have all been related to UI-Bootstrap's 0.14 version, which still supports Angular 1.3 and 1.4.

Archelyst commented 8 years ago

+1 for this change

dougmoscrop commented 8 years ago

Maybe we could get through few of the other PRs, release a version, then move on to this?

niemyjski commented 8 years ago

I need this change as well before I can upgrade to the new version. I have logging in my app that sends to a third party service (https://github.com/exceptionless/Exceptionless) and I get like 30 warning messages per client.

niemyjski commented 8 years ago

@dougmoscrop @m-e-conroy I don't see anything wrong with this commit on why it shouldn't be merged. If the consensus is to merge it I can click the button.

dougmoscrop commented 8 years ago

The commit itself looks fine to me too. I'm :+1: for you to merge but wish we had Travis or something set up so the tests would be run.

niemyjski commented 8 years ago

I'm going to merge this and test as well. Can you all do this as well.

m-e-conroy commented 8 years ago

Yeah, I think we should update to support newest versions. Actually only noticed the name changes in Ui-bootstrap this past week. On Oct 29, 2015 12:06 PM, "Blake Niemyjski" notifications@github.com wrote:

@m-e-conroy https://github.com/m-e-conroy @NealHaggard https://github.com/NealHaggard does it make sense to even support 1.3 anymore? 1.4.7 is out and 1.5 is on the verge of release. Would be nice to update all the dependencies to 1.4.7 too.

— Reply to this email directly or view it on GitHub https://github.com/m-e-conroy/angular-dialog-service/pull/146#issuecomment-152227379 .