Closed wcomartin closed 8 years ago
@niemyjski or @m-e-conroy please take a look
As Discussed in PR https://github.com/m-e-conroy/angular-dialog-service/pull/141
I don't have 100% coverage, i added tests for controllers and the "dialogs" service and provider, need to add testing for translating
@m-e-conroy Looks good to me.
:+1: from me too -- maybe kill the blocks of commented code, then I can merge.
@niemyjski or @m-e-conroy please take a look
As Discussed in PR https://github.com/m-e-conroy/angular-dialog-service/pull/141
I don't have 100% coverage, i added tests for controllers and the "dialogs" service and provider, need to add testing for translating