search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Adding Unit Tests #147

Closed wcomartin closed 8 years ago

wcomartin commented 8 years ago

@niemyjski or @m-e-conroy please take a look

As Discussed in PR https://github.com/m-e-conroy/angular-dialog-service/pull/141

I don't have 100% coverage, i added tests for controllers and the "dialogs" service and provider, need to add testing for translating

niemyjski commented 8 years ago

@m-e-conroy Looks good to me.

dougmoscrop commented 8 years ago

:+1: from me too -- maybe kill the blocks of commented code, then I can merge.