search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

updated 'main' property to comply with NPM requirements #152

Closed shainegordon closed 8 years ago

shainegordon commented 8 years ago

this change allows the package to be installed via npm. the property main in package.json is not valid as an array

the index.js has also been updated to not point to the minified files, as this can cause issues when using tools like webpack

niemyjski commented 8 years ago

Have you done testing with this? Is this still good?

Looks like the main only takes an id like we have specified in your pr.

The main field is a module ID that is the primary entry point to your program. That is, if your package is named foo, and a user installs it, and then does require("foo"), then your main module's exports object will be returned.

This should be a module ID relative to the root of your package folder.

For most modules, it makes the most sense to have a main script and often not much else.
niemyjski commented 8 years ago

I'm closing this via: https://github.com/m-e-conroy/angular-dialog-service/pull/152

shainegordon commented 8 years ago

Thanks, seems that #168 covers all the changes in here too.