m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Options object #159

Open dougmoscrop opened 8 years ago

dougmoscrop commented 8 years ago

Let's refactor .create to take an options object.

I propose that since the current version takes URL as the first parameter, it's probably always true that arguments.length >= 1 and that arguments[0] is a string, therefore if arguments.length === 1 and arguments[0] is an object, they're using the proposed new style. I believe this should be backwards compatible.

Schedule:

Thoughts?

venil7 commented 8 years ago

Sounds good! I would however introduce new option in next minor, then - deprecate in next next minor, then - remove in next major to stay semver