Closed dgsmith2 closed 8 years ago
@dgsmith2 can you please bump the minor version. Last time we just incremented the revision on a major dependency upgrade people got pissed :( (was my fault).
@niemyjski done!
@dgsmith2 do you think we should just bump everything to 1.5?
I erred on the side of caution and went with 1.4 to mimic the version of Angular angular-bootstrap depends on.
I'm not 100% up to speed on the philosophy of specifying dependency versions, so forgive any naivety in the following question. Should you not specify the earliest supported/compatible version? By specifying 1.5 are you not saying it isn't supported on 1.4?
Yes, it's saying the recommended / requires 1.5, which means we only have to support the latest which is kind of nice and next week someone isn't asking us to bump the version again lol
@m-e-conroy thoughts?
Sorry, was away on vacation. I'm all for bumping to 1.5 and only supporting the latest versions.
@dgsmith2 can you bump this up and I'll create a release
Done!
Updated angular-bootstrap to 1.1.2 in order to address #164. Also fixed pre-existing broken unit tests