search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Angular bootstrap 1.1.2 #166

Closed dgsmith2 closed 8 years ago

dgsmith2 commented 8 years ago

Updated angular-bootstrap to 1.1.2 in order to address #164. Also fixed pre-existing broken unit tests

niemyjski commented 8 years ago

@dgsmith2 can you please bump the minor version. Last time we just incremented the revision on a major dependency upgrade people got pissed :( (was my fault).

dgsmith2 commented 8 years ago

@niemyjski done!

niemyjski commented 8 years ago

@dgsmith2 do you think we should just bump everything to 1.5?

dgsmith2 commented 8 years ago

I erred on the side of caution and went with 1.4 to mimic the version of Angular angular-bootstrap depends on.

I'm not 100% up to speed on the philosophy of specifying dependency versions, so forgive any naivety in the following question. Should you not specify the earliest supported/compatible version? By specifying 1.5 are you not saying it isn't supported on 1.4?

niemyjski commented 8 years ago

Yes, it's saying the recommended / requires 1.5, which means we only have to support the latest which is kind of nice and next week someone isn't asking us to bump the version again lol

niemyjski commented 8 years ago

@m-e-conroy thoughts?

m-e-conroy commented 8 years ago

Sorry, was away on vacation. I'm all for bumping to 1.5 and only supporting the latest versions.

niemyjski commented 8 years ago

@dgsmith2 can you bump this up and I'll create a release

dgsmith2 commented 8 years ago

Done!