m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

the translation for chinese does not work. #167

Closed Agileaq closed 8 years ago

Agileaq commented 8 years ago

I added one line `

<button class="btn btn-default" ng-click="setLanguage('es')">Spanish</button>
**<button class="btn btn-default" ng-click="setLanguage('zh-CN')">Chinese</button>**

and changed the dialogTest.js file : $scope.$watch('lang',function(val,old){ switch(val){ case 'en-US': $scope.language = 'English'; break; case 'es': $scope.language = 'Spanish'; break; case 'zh-CN': $scope.language = 'Chinese'; break; } });` then I run index.html and click on the btn, I get gibberish...

giblish

m-e-conroy commented 8 years ago

Did you add the translations for Chinese?

This doesn't automatically translate text for you like Google Translate. You need to supply the translations, all that happens is a substitution by Angular-Translate when the language setting is changed.