search

m-e-conroy / angular-dialog-service

A complete AngularJS service with controllers and templates for generating application modals and dialogs for use with Angular-UI-Bootstrap and Twitter Bootstrap
MIT License
618 stars 228 forks source link

Align with npm spec for "main" #168

Closed dgsmith2 closed 8 years ago

dgsmith2 commented 8 years ago

https://docs.npmjs.com/files/package.json#main

niemyjski commented 8 years ago

Can you bump the version down to 5.3.0, we've yet to release it so npm or bower won't pick it up until we create a release.

niemyjski commented 8 years ago

Could you also merge in these changes :) https://github.com/m-e-conroy/angular-dialog-service/pull/141

niemyjski commented 8 years ago

@dgsmith2 can you also merge this in: https://github.com/m-e-conroy/angular-dialog-service/pull/152 if the changes make sense.

dgsmith2 commented 8 years ago

@niemyjski, no clue if I did the merges correctly in the context of Github and PRs.

I added the other 2 forks as remotes and merged in the latest commits from the referenced PRs.

niemyjski commented 8 years ago

@dgsmith2 thanks! If it looks good to you let me know and I'll merge it. I use this without requirejs / node so I can't really test this change too much.

dgsmith2 commented 8 years ago

@niemyjski, best I can tell it is working fine for me.

We just are making the move from Bower to npm. Our first stab is manually specifying the necessary files in node_modules/.... So, I can't speak just yet to the likes of using any of the client-side packaging tools.

niemyjski commented 8 years ago

Thank you!